[GitHub] [incubator-netbeans] matthiasblaesing commented on issue #1177: [NETBEANS-2318] Remove synchronized elements from SQLEditorSupport

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #1177: [NETBEANS-2318] Remove synchronized elements from SQLEditorSupport
URL: https://github.com/apache/incubator-netbeans/pull/1177#issuecomment-478065405
 
 
   Sorry - I missed the description in this PR. The intention of this PR is to change nothing on the user facing side. All processes in the GUI and below stay the same. The issue is: When closing an SQL editor, there is a change, that there is a deadlock. This blocks the UI indefinitely and thus you have to kill netbeans.
   
   The root of the deadlock lies in the fact, that a UI thread and a RequestProcessor both try to access synchronized functions in SQLEditorSupport. This PR removes the synchronized primitives and 
   a) either replaces them with volatile variables (the changes around dbcon and executing) or
   b) introduce a more finegrained lock, that has less potential for lock conflicts (logger).
   
   I think you are thinking about a different issue (code completion without an sql connection).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists