You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/06/24 05:53:45 UTC

[Bug 122576] New: Attempting to delete an Ole object crashes

https://issues.apache.org/ooo/show_bug.cgi?id=122576

            Bug ID: 122576
        Issue Type: DEFECT
           Summary: Attempting to delete an Ole object crashes
           Product: Writer
           Version: AOO 3.4.1
          Hardware: PC
                OS: Windows Vista
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: editing
          Assignee: issues@openoffice.apache.org
          Reporter: jpwright@sonic.net
                CC: issues@openoffice.apache.org

Created attachment 80903
  --> https://issues.apache.org/ooo/attachment.cgi?id=80903&action=edit
Webpage clip featuring Alan Greenspan

I copied and pasted from a web page into OpenOffice Writer.

Pressing F5 to bring up the Navigator and then attempting to delete either of
the Ole objects causes a crash.

I'm running MS Vista and OpenOffice 3.4.1

Thanks for looking into this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #9 from SVN Robot <sv...@dev.null.org> ---
"af" committed SVN revision 1569241 into trunk:
122576: Reset the docking area acceptor in the destructor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

fanyuzhen@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fanyuzhen@gmail.com

--- Comment #15 from fanyuzhen@gmail.com ---
Shao Zhi, please use the latest build to check again, e.g. 1571492

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Edwin Sharp <el...@mail-page.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |elish@mail-page.com
             Latest|---                         |AOO 4.0.0
    Confirmation on|                            |
     Ever confirmed|0                           |1

--- Comment #1 from Edwin Sharp <el...@mail-page.com> ---
Thank you for reporting this bug.

Crash with Rev. 1489073 Win 7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #13 from zhaoshzh <ao...@gmail.com> ---
the build version:
Dev Snapshot Apache OpenOffice 4.1.0 - full installation sets

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #14 from zhaoshzh <ao...@gmail.com> ---
test on AOO410m1(build:9750) - rev:1566593

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com
         QA Contact|                            |awf.aoo@googlemail.com

--- Comment #4 from Andre <aw...@googlemail.com> ---
A LayoutManager (for this document four are created) is destroyed and then
called (as WindowEvent listener).  This post-mortem callback accesses resources
that are no longer available (in my case a mutex that has been set to NULL in
the meantime).

It should be enough to unregister the listener in ~LayoutManager.  I also have
to look at why the LayoutManager is destroyed, ie what does it manage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #6 from Andre <aw...@googlemail.com> ---
Sorry, please ignore my last comment.  It was meant for another issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Oliver-Rainer Wittmann <or...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.1.0

--- Comment #11 from Oliver-Rainer Wittmann <or...@apache.org> ---
Yes, this is more or less the same problem as bug 124096.
@Andre: I would like to have a further discussion on both solutions in the next
days. I will get in contact with you.

Note:
Providing corresponding issue data to reflect that this issue is fixed for the
next release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|issues@openoffice.apache.or |awf.aoo@googlemail.com
                   |g                           |

--- Comment #7 from Andre <aw...@googlemail.com> ---
When I return from the WindowEventListener when I detect the called object has
been deleted then there is no crash.  So it looks like the event callback of
the dead layout manager is the main (and hopefully) only problem.

Deleting the OLE object seems to activate the OLE object first.  This in turn
creates a couple of new layout managers.  I find that a bit unexpected.

I still have to figure out how to best keep track of the many registered window
listeners.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |UNCONFIRMED
                 CC|                            |Armin.Le.Grand@me.com
             Latest|AOO 4.0.0                   |---
    Confirmation on|                            |
     Ever confirmed|1                           |0

--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
ALG: Crash in EmbeddedObjectContainer::GetEmbeddedObject in comphelper, given
::rtl::OUString& rName looks bad.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |crash, regression
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |rainerbielefeld_ooo_qa@biel
                   |                            |efeldundbuss.de
             Latest|---                         |4.0.0
    Confirmation on|                            |
            Version|3.4.1                       |3.4.0
     Ever confirmed|0                           |1
                 OS|Windows Vista               |Windows, all

--- Comment #3 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
CRASH still  Reproducible with  "AOO 4.1.0-Dev – English  UI / German locale -
[AOO410m1(Build:9750)  -  Rev. 1516435  2013-08-24]" on German WIN7 Home
Premium (64bit)", own separate user profile.

Already CRASH with 3.4.0, was OK with OOo 3.3.0, so REGRESSION

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|awf.aoo@googlemail.com      |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #5 from Andre <aw...@googlemail.com> ---
I updated my local source tree to revision 1567914 and now I am not able to
reproduce this bug anymore.  Does anybody else still see the crash?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

--- Comment #8 from Andre <aw...@googlemail.com> ---
I really don't want to sound too negative, but the management of the window
listeners really is a mess.  And that is not the only bad thing.  I can only
hope that nobody uses the layout manager to create a docking window.  In method
LayoutManager::createElement(), the section for handling element type
"dockingwindow" not only registers itself as window listener at the newly
created window (via impl_addWindowListeners()), it also calls
    m_pPanelManager->addDockingWindow( aName, xUIElement );
The problem with this line is that m_pPanelManger is a private member that is
never initialized to a non-null value (and LayoutManager has no friends which
would do that for it).  And really, whenever createElement() is called,
m_pPanelManger is NULL.  It is so good, that the "dockingwindow" section is
never activated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Issue 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org

--- Comment #16 from jsc@apache.org ---
verified on MacOS 

OO410m14(Build:9760)  -  Rev. 1582710
2014-03-28 11:34:22 (Fri, 28 Mar 2014)

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Issue 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #17 from jsc@apache.org ---
verified with AOO 4.1.0 RC on MacOS and Windows

AOO410m15(Build:9761)  -  Rev. 1583666
2014-04-01 13:46:49 (Tue, 01 Apr 2014)

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Andre <aw...@googlemail.com> ---
Just when I wanted to check in my changes I discovered that bug 124096
describes a very similar problem and had just been fixed with almost the
identical solution (calling setDockingAreaAcceptor(NULL) from within
disposing() when the frame is disposed).
To be on the safe side I added a similar call to the destructor of
LayoutManager.

Calling setDockingAreaAcceptor(NULL) unregisters the window listeners.  But it
has to be done before the frame is disposed or otherwise
setDockingAreaAcceptor() leaves without doing anything.  For this reason the
call in the destructor usually does nothing.  I added it just in case the frame
is not disposed or disposed after the layoutmanager.  I think the later should
be the case but then again LayoutManager itself is never disposed, so it looks
like the destruction sequence is not so well defined.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 122576] Attempting to delete an Ole object crashes

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122576

zhaoshzh <ao...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoo.zhaoshzh@gmail.com

--- Comment #12 from zhaoshzh <ao...@gmail.com> ---
Created attachment 82706
  --> https://issues.apache.org/ooo/attachment.cgi?id=82706&action=edit
aoo freeze when open the sample file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.