[GitHub] [pinot] chenboat commented on a diff in pull request #10752: Minor Pinot Deepstore Upload Retry Task Improvements

["chenboat (via GitHub)" <gi...@apache.org>]

chenboat commented on code in PR #10752:
URL: https://github.com/apache/pinot/pull/10752#discussion_r1195833919


##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -468,7 +468,8 @@ public Response downloadValidDocIds(
    * Upload a low level consumer segment to segment store and return the segment download url. This endpoint is used
    * when segment store copy is unavailable for committed low level consumer segments.
    * Please note that invocation of this endpoint may cause query performance to suffer, since we tar up the segment
-   * to upload it.
+   * to upload it. There's a query parameter to configure how long the segment-uploader should wait for the upload to
+   * deep-store to finish.

Review Comment:
   Can you add javadoc on what default value -1 means?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org