You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 23:58:32 UTC
[GitHub] [spark] allisonwang-db opened a new pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
allisonwang-db opened a new pull request #30373:
URL: https://github.com/apache/spark/pull/30373
### What changes were proposed in this pull request?
This PR is a follow-up for #30093. It
1. Swiched the order for the rule `RemoveRedundantSorts` and `EnsureRequirements` so that `EnsureRequirements` will be invoked before `RemoveRedundantSorts`. This change will be backported to 3.0 and 2.4 as well.
2. Updated the config `spark.sql.execution.removeRedundantSorts` version to 2.4.8.
### Why are the changes needed?
1. To avoid IllegalArgumentException when instantiating `PartitioningCollection` before `EnsureRequirements`:
```
IllegalArgumentException: requirement failed: PartitioningCollection requires all of its partitionings have the same numPartitions.
```
2. To update the rule version it has been backported to 2.4.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729501074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-731300083
Thank you, @allisonwang-db , @maropu , @cloud-fan !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727142229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729728458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729728438
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35887/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727142042
**[Test build #131085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131085/testReport)** for PR 30373 at commit [`e6b0bb3`](https://github.com/apache/spark/commit/e6b0bb301d928ce8e9970ec8b887ff06e3110b6d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729323717
**[Test build #131240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131240/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729344731
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730201293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a change in pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
allisonwang-db commented on a change in pull request #30373:
URL: https://github.com/apache/spark/pull/30373#discussion_r529206352
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -343,8 +343,10 @@ object QueryExecution {
PlanDynamicPruningFilters(sparkSession),
PlanSubqueries(sparkSession),
RemoveRedundantProjects,
- RemoveRedundantSorts,
EnsureRequirements,
+ // `RemoveRedundantSorts` needs to be added before `EnsureRequirements` to guarantee the same
Review comment:
Thanks for catching it! Will create a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730153287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730201303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131319/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729323717
**[Test build #131240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131240/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730153277
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35923/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729681769
**[Test build #131282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131282/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729803316
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729344731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730201293
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729501085
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35859/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729728458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729344721
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35844/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730153287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727106355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727142229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729490026
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35859/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729448443
**[Test build #131256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131256/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727106355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729508408
**[Test build #131256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131256/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729508940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729803316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727092021
**[Test build #131085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131085/testReport)** for PR 30373 at commit [`e6b0bb3`](https://github.com/apache/spark/commit/e6b0bb301d928ce8e9970ec8b887ff06e3110b6d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730375548
@allisonwang-db can you create backport PRs for 2.4 and 3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30373:
URL: https://github.com/apache/spark/pull/30373#discussion_r523421228
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -343,8 +343,8 @@ object QueryExecution {
PlanDynamicPruningFilters,
PlanSubqueries,
RemoveRedundantProjects,
- RemoveRedundantSorts,
EnsureRequirements,
+ RemoveRedundantSorts,
Review comment:
Could you leave some comments here about why we need to put this rule after `EnsureRequirements`?
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala
##########
@@ -135,6 +135,26 @@ abstract class RemoveRedundantSortsSuiteBase
}
}
}
+
+ test("shuffled join with different left and right side partition numbers") {
Review comment:
nit: could you add the prefix: `SPARK-33183: `
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantSortsSuite.scala
##########
@@ -135,6 +135,26 @@ abstract class RemoveRedundantSortsSuiteBase
}
}
}
+
+ test("shuffled join with different left and right side partition numbers") {
+ withTempView("t1", "t2") {
+ spark.range(0, 100, 1, 2).select('id as "key").createOrReplaceTempView("t1")
+ (0 to 100).toDF("key").createOrReplaceTempView("t2")
+
+ // left side partitioning: RangePartitioning(key ASC, 2)
+ // right side partitioning: UnknownPartitioning(0)
Review comment:
Could you add `assert` to check if the query below has the output partitions above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730128384
**[Test build #131319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131319/testReport)** for PR 30373 at commit [`4e684df`](https://github.com/apache/spark/commit/4e684df701c9421eba105d469b0338a5320ce42c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30373:
URL: https://github.com/apache/spark/pull/30373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729387013
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730142442
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35923/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30373:
URL: https://github.com/apache/spark/pull/30373#discussion_r528260491
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -343,8 +343,10 @@ object QueryExecution {
PlanDynamicPruningFilters(sparkSession),
PlanSubqueries(sparkSession),
RemoveRedundantProjects,
- RemoveRedundantSorts,
EnsureRequirements,
+ // `RemoveRedundantSorts` needs to be added before `EnsureRequirements` to guarantee the same
Review comment:
Ah, I missed it. @allisonwang-db could you fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729679891
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729404332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729508940
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729448443
**[Test build #131256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131256/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727092021
**[Test build #131085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131085/testReport)** for PR 30373 at commit [`e6b0bb3`](https://github.com/apache/spark/commit/e6b0bb301d928ce8e9970ec8b887ff06e3110b6d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729803330
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131282/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #30373:
URL: https://github.com/apache/spark/pull/30373#discussion_r528221098
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -343,8 +343,10 @@ object QueryExecution {
PlanDynamicPruningFilters(sparkSession),
PlanSubqueries(sparkSession),
RemoveRedundantProjects,
- RemoveRedundantSorts,
EnsureRequirements,
+ // `RemoveRedundantSorts` needs to be added before `EnsureRequirements` to guarantee the same
Review comment:
before -> after ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729337615
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35844/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729708593
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35887/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730200932
**[Test build #131319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131319/testReport)** for PR 30373 at commit [`4e684df`](https://github.com/apache/spark/commit/4e684df701c9421eba105d469b0338a5320ce42c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729508947
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131256/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729404332
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30373:
URL: https://github.com/apache/spark/pull/30373#discussion_r525322345
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -343,8 +343,8 @@ object QueryExecution {
PlanDynamicPruningFilters,
PlanSubqueries,
RemoveRedundantProjects,
- RemoveRedundantSorts,
EnsureRequirements,
+ RemoveRedundantSorts,
Review comment:
+1 for @maropu 's comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730375331
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729501074
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727102110
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35688/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729404338
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131240/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-730128384
**[Test build #131319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131319/testReport)** for PR 30373 at commit [`4e684df`](https://github.com/apache/spark/commit/4e684df701c9421eba105d469b0338a5320ce42c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33183][SQL][FOLLOW-UP] Adjust RemoveRedundantSorts rule order and update config version
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-727106353
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35688/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729344743
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35844/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729802552
**[Test build #131282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131282/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729404075
**[Test build #131240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131240/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729447776
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729501057
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35859/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30373: [SPARK-33472][SQL] Adjust RemoveRedundantSorts rule order
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30373:
URL: https://github.com/apache/spark/pull/30373#issuecomment-729681769
**[Test build #131282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131282/testReport)** for PR 30373 at commit [`fa6050a`](https://github.com/apache/spark/commit/fa6050aa6b72ef5aa69cf0703acac63f447e9303).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org