You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Anitka <gi...@git.apache.org> on 2015/05/20 21:45:20 UTC
[GitHub] jmeter pull request: Extended JMSSampler
GitHub user Anitka opened a pull request:
https://github.com/apache/jmeter/pull/17
Extended JMSSampler
I extended the JMSSampler as when we use byte messages then it is impossible to e.g. make any assertions (all of them fail). I added a case when message is byte message and then I converted it to string. Then assertions work as it is expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Anitka/jmeter trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit b85089e7e0ccbc8cd63723931172bcb131936853
Author: Anita Ciosek <an...@sabre.com>
Date: 2015-05-20T19:37:59Z
Extended JMSSampler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Extended JMSSampler
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: Github comments on dev mailing-list | Fwd: [GitHub]
jmeter pull request: Extended JMSSampler
Posted by Milamber <mi...@apache.org>.
Notifications of comments enabled (some tests today on dev list)
For reference, the Infra Ticket:
https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9720
On 26/05/2015 20:43, Philippe Mouawad wrote:
> +1 for me.
>
> On Tue, May 26, 2015 at 7:08 PM, sebb <se...@gmail.com> wrote:
>
>> OK by me.
>>
>> I imagine it's a setting that Infra will have to tweak.
>>
>> On 26 May 2015 at 06:05, Felix Schumacher
>> <fe...@internetallee.de> wrote:
>>> Am Freitag, den 22.05.2015, 17:18 +0100 schrieb Milamber:
>>>> Hello
>>>>
>>>> Philippe has post a comment to Anitka on Github for this pull request,
>>>> but we don't receive a copy on mailing-list. On the Cloudstack project
>>>> we receive an email for each comments (and for the close message) on the
>>>> Github clone project.
>>>>
>>>> I think that's a good thing to follow the PR lifecycle on the dev
>>>> mailing list directly.
>>>>
>>>> If you are agreed, I can find the way to do this.
>>> +1
>>>
>>> I would like to be informed on any updates from the github repository.
>>>
>>> Regards
>>> Felix
>>>
>>>> Milamber
>>>>
>>>> -------- Forwarded Message --------
>>>> Subject: [GitHub] jmeter pull request: Extended JMSSampler
>>>> Date: Wed, 20 May 2015 19:45:20 +0000 (UTC)
>>>> From: Anitka <gi...@git.apache.org>
>>>> Reply-To: dev@jmeter.apache.org, dev@jmeter.apache.org
>>>> To: dev@jmeter.apache.org
>>>>
>>>>
>>>>
>>>> GitHub user Anitka opened a pull request:
>>>>
>>>> https://github.com/apache/jmeter/pull/17
>>>>
>>>> Extended JMSSampler
>>>>
>>>> I extended the JMSSampler as when we use byte messages then it is
>> impossible to e.g. make any assertions (all of them fail). I added a case
>> when message is byte message and then I converted it to string. Then
>> assertions work as it is expected.
>>>> You can merge this pull request into a Git repository by running:
>>>>
>>>> $ git pull https://github.com/Anitka/jmeter trunk
>>>>
>>>> Alternatively you can review and apply these changes as the patch at:
>>>>
>>>> https://github.com/apache/jmeter/pull/17.patch
>>>>
>>>> To close this pull request, make a commit to your master/trunk branch
>>>> with (at least) the following in the commit message:
>>>>
>>>> This closes #17
>>>>
>>>> ----
>>>> commit b85089e7e0ccbc8cd63723931172bcb131936853
>>>> Author: Anita Ciosek <an...@sabre.com>
>>>> Date: 2015-05-20T19:37:59Z
>>>>
>>>> Extended JMSSampler
>>>>
>>>> ----
>>>>
>>>>
>>>> ---
>>>> If your project is set up for it, you can reply to this email and have
>> your
>>>> reply appear on GitHub as well. If your project does not have this
>> feature
>>>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>> ticket
>>>> with INFRA.
>>>> ---
>>>>
>>>
>
>
Re: Github comments on dev mailing-list | Fwd: [GitHub] jmeter pull
request: Extended JMSSampler
Posted by Philippe Mouawad <ph...@gmail.com>.
+1 for me.
On Tue, May 26, 2015 at 7:08 PM, sebb <se...@gmail.com> wrote:
> OK by me.
>
> I imagine it's a setting that Infra will have to tweak.
>
> On 26 May 2015 at 06:05, Felix Schumacher
> <fe...@internetallee.de> wrote:
> > Am Freitag, den 22.05.2015, 17:18 +0100 schrieb Milamber:
> >> Hello
> >>
> >> Philippe has post a comment to Anitka on Github for this pull request,
> >> but we don't receive a copy on mailing-list. On the Cloudstack project
> >> we receive an email for each comments (and for the close message) on the
> >> Github clone project.
> >>
> >> I think that's a good thing to follow the PR lifecycle on the dev
> >> mailing list directly.
> >>
> >> If you are agreed, I can find the way to do this.
> > +1
> >
> > I would like to be informed on any updates from the github repository.
> >
> > Regards
> > Felix
> >
> >>
> >> Milamber
> >>
> >> -------- Forwarded Message --------
> >> Subject: [GitHub] jmeter pull request: Extended JMSSampler
> >> Date: Wed, 20 May 2015 19:45:20 +0000 (UTC)
> >> From: Anitka <gi...@git.apache.org>
> >> Reply-To: dev@jmeter.apache.org, dev@jmeter.apache.org
> >> To: dev@jmeter.apache.org
> >>
> >>
> >>
> >> GitHub user Anitka opened a pull request:
> >>
> >> https://github.com/apache/jmeter/pull/17
> >>
> >> Extended JMSSampler
> >>
> >> I extended the JMSSampler as when we use byte messages then it is
> impossible to e.g. make any assertions (all of them fail). I added a case
> when message is byte message and then I converted it to string. Then
> assertions work as it is expected.
> >>
> >> You can merge this pull request into a Git repository by running:
> >>
> >> $ git pull https://github.com/Anitka/jmeter trunk
> >>
> >> Alternatively you can review and apply these changes as the patch at:
> >>
> >> https://github.com/apache/jmeter/pull/17.patch
> >>
> >> To close this pull request, make a commit to your master/trunk branch
> >> with (at least) the following in the commit message:
> >>
> >> This closes #17
> >>
> >> ----
> >> commit b85089e7e0ccbc8cd63723931172bcb131936853
> >> Author: Anita Ciosek <an...@sabre.com>
> >> Date: 2015-05-20T19:37:59Z
> >>
> >> Extended JMSSampler
> >>
> >> ----
> >>
> >>
> >> ---
> >> If your project is set up for it, you can reply to this email and have
> your
> >> reply appear on GitHub as well. If your project does not have this
> feature
> >> enabled and wishes so, or if the feature is enabled but not working,
> please
> >> contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> >> with INFRA.
> >> ---
> >>
> >
> >
>
--
Cordialement.
Philippe Mouawad.
Re: Github comments on dev mailing-list | Fwd: [GitHub] jmeter pull
request: Extended JMSSampler
Posted by sebb <se...@gmail.com>.
OK by me.
I imagine it's a setting that Infra will have to tweak.
On 26 May 2015 at 06:05, Felix Schumacher
<fe...@internetallee.de> wrote:
> Am Freitag, den 22.05.2015, 17:18 +0100 schrieb Milamber:
>> Hello
>>
>> Philippe has post a comment to Anitka on Github for this pull request,
>> but we don't receive a copy on mailing-list. On the Cloudstack project
>> we receive an email for each comments (and for the close message) on the
>> Github clone project.
>>
>> I think that's a good thing to follow the PR lifecycle on the dev
>> mailing list directly.
>>
>> If you are agreed, I can find the way to do this.
> +1
>
> I would like to be informed on any updates from the github repository.
>
> Regards
> Felix
>
>>
>> Milamber
>>
>> -------- Forwarded Message --------
>> Subject: [GitHub] jmeter pull request: Extended JMSSampler
>> Date: Wed, 20 May 2015 19:45:20 +0000 (UTC)
>> From: Anitka <gi...@git.apache.org>
>> Reply-To: dev@jmeter.apache.org, dev@jmeter.apache.org
>> To: dev@jmeter.apache.org
>>
>>
>>
>> GitHub user Anitka opened a pull request:
>>
>> https://github.com/apache/jmeter/pull/17
>>
>> Extended JMSSampler
>>
>> I extended the JMSSampler as when we use byte messages then it is impossible to e.g. make any assertions (all of them fail). I added a case when message is byte message and then I converted it to string. Then assertions work as it is expected.
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/Anitka/jmeter trunk
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/jmeter/pull/17.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #17
>>
>> ----
>> commit b85089e7e0ccbc8cd63723931172bcb131936853
>> Author: Anita Ciosek <an...@sabre.com>
>> Date: 2015-05-20T19:37:59Z
>>
>> Extended JMSSampler
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
Re: Github comments on dev mailing-list | Fwd: [GitHub] jmeter pull
request: Extended JMSSampler
Posted by Felix Schumacher <fe...@internetallee.de>.
Am Freitag, den 22.05.2015, 17:18 +0100 schrieb Milamber:
> Hello
>
> Philippe has post a comment to Anitka on Github for this pull request,
> but we don't receive a copy on mailing-list. On the Cloudstack project
> we receive an email for each comments (and for the close message) on the
> Github clone project.
>
> I think that's a good thing to follow the PR lifecycle on the dev
> mailing list directly.
>
> If you are agreed, I can find the way to do this.
+1
I would like to be informed on any updates from the github repository.
Regards
Felix
>
> Milamber
>
> -------- Forwarded Message --------
> Subject: [GitHub] jmeter pull request: Extended JMSSampler
> Date: Wed, 20 May 2015 19:45:20 +0000 (UTC)
> From: Anitka <gi...@git.apache.org>
> Reply-To: dev@jmeter.apache.org, dev@jmeter.apache.org
> To: dev@jmeter.apache.org
>
>
>
> GitHub user Anitka opened a pull request:
>
> https://github.com/apache/jmeter/pull/17
>
> Extended JMSSampler
>
> I extended the JMSSampler as when we use byte messages then it is impossible to e.g. make any assertions (all of them fail). I added a case when message is byte message and then I converted it to string. Then assertions work as it is expected.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/Anitka/jmeter trunk
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/jmeter/pull/17.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #17
>
> ----
> commit b85089e7e0ccbc8cd63723931172bcb131936853
> Author: Anita Ciosek <an...@sabre.com>
> Date: 2015-05-20T19:37:59Z
>
> Extended JMSSampler
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
Github comments on dev mailing-list | Fwd: [GitHub] jmeter
pull request: Extended JMSSampler
Posted by Milamber <mi...@apache.org>.
Hello
Philippe has post a comment to Anitka on Github for this pull request,
but we don't receive a copy on mailing-list. On the Cloudstack project
we receive an email for each comments (and for the close message) on the
Github clone project.
I think that's a good thing to follow the PR lifecycle on the dev
mailing list directly.
If you are agreed, I can find the way to do this.
Milamber
-------- Forwarded Message --------
Subject: [GitHub] jmeter pull request: Extended JMSSampler
Date: Wed, 20 May 2015 19:45:20 +0000 (UTC)
From: Anitka <gi...@git.apache.org>
Reply-To: dev@jmeter.apache.org, dev@jmeter.apache.org
To: dev@jmeter.apache.org
GitHub user Anitka opened a pull request:
https://github.com/apache/jmeter/pull/17
Extended JMSSampler
I extended the JMSSampler as when we use byte messages then it is impossible to e.g. make any assertions (all of them fail). I added a case when message is byte message and then I converted it to string. Then assertions work as it is expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Anitka/jmeter trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit b85089e7e0ccbc8cd63723931172bcb131936853
Author: Anita Ciosek <an...@sabre.com>
Date: 2015-05-20T19:37:59Z
Extended JMSSampler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---