You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 16:28:55 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2118: Add cmake support for C# netstd
emmenlau opened a new pull request #2118:
URL: https://github.com/apache/thrift/pull/2118
This PR adds cmake support for the C# netstd implementation. The major changes are only in cmake and in the Visual Studio project files. The actual build is executed via `dotnet` (which has to be installed). cmake only orchestrates the build and can install the build artifacts.
A major change is that this PR fixes issue https://issues.apache.org/jira/browse/THRIFT-5143 for me. The required change is that the Thrift build for netstandard 2.0 can not be mixed and mingled with application builds for netstandard 2.0 or .net Framework, due to a missing dependency to reference assembly `System.Threading.Tasks.Extensions, Version=4.2.0.1`. This can be resolved by referencing the Thrift library artifact instead of the Thrift project file. See the Jira issue for a more detailed discussion.
I've tested the build on Windows, macOS and Linux successfully.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- Full cmake support is in a single commit. There are two other, minor changes to C# code in two other commits in this same PR.
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-683264696
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-751239343
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] zeshuai007 commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
zeshuai007 commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-715852430
It looks like broken the automake for C# netstd,too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-683259659
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-778357295
This issue is no longer stale. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested.
Except of course that CI is all red.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619847306
The problem with the CI is not easily fixed for me. The issue comes from the fact that the autotools build does not resolve the dependency between tests and the Thrift library in the same way as I encoded it in cmake. A solution would be to encode these inter-dependencies in Thrift.sln.
But sadly I'm not knowledgeable enough in Visual Studio or autotools to fix either of these. Can someone help? If not, I guess this PR will need to wait...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-683264700
This issue is no longer stale. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616
+1 LGTM but not tested.
Except of course that CI is all red.
Do we need to update documents (like *md) maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-702392592
Rebase still needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2118: Add cmake support for C# netstd
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2118:
URL: https://github.com/apache/thrift/pull/2118#issuecomment-778357703
Updated to latest master, and various minor issues fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org