You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/24 18:02:28 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #12242: ARROW-15433: [Doc] Fix warnings when building

lidavidm commented on a change in pull request #12242:
URL: https://github.com/apache/arrow/pull/12242#discussion_r791019402



##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -46,7 +46,7 @@ class ExecContext;
 class ARROW_EXPORT ScalarAggregateOptions : public FunctionOptions {
  public:
   explicit ScalarAggregateOptions(bool skip_nulls = true, uint32_t min_count = 1);
-  constexpr static char const kTypeName[] = "ScalarAggregateOptions";
+  static constexpr char const kTypeName[] = "ScalarAggregateOptions";

Review comment:
       I think it's fine, though it would be nice to get it fixed upstream eventually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org