You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "faga295 (via GitHub)" <gi...@apache.org> on 2026/09/07 08:17:53 UTC
[PR] fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop [maka]
faga295 opened a new pull request, #4967:
URL: https://github.com/apache/maka/pull/4967
## Summary
Fixes a severe performance issue when a Session terminal panel is open: the UI stayed laggy with sustained CPU usage even while the terminal was idle, and worsened as output accumulated.
Root cause — a layout feedback loop:
- `.maka-session-workbar-panel[data-overlay][data-placement="right"]` is `display: grid` but declared **no explicit row track**, so content fell into an implicit `auto` row;
- an `auto` row's size includes its contents' min-content contribution, so the Section inner wrapper (`height: 100%`) and the terminal panel (`height: 100%`) grew with xterm's output;
- that fired `ResizeObserver` → xterm `fit()` → layout changed → observer fired again: a `ResizeObserver → fit → resize → grow` loop on every burst of output.
The fix declares an explicit track, `grid-template-rows: minmax(0, 1fr)`: the `1fr` sizes the track purely from the container's definite height so content no longer participates in track sizing, and `min 0` removes the auto row's min-content floor — cutting the loop at its root.
## Testing
- Added an e2e assertion (`Terminal fits its panel without growing and stops when its Session changes`): across 12 consecutive `requestAnimationFrame` ticks the xterm host stays within the panel bounds. Fails without the CSS change, passes with it.
- Full `session-workbar.spec.ts` passes (6/6); verified the other overlay panels (review / browser / files / inspector / side-chat) have `height: 100%` roots and are unaffected, and the wide-window collapse animation's `display: grid` restore rule still applies.
- `npm run typecheck` and `check:e2e-budget` pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop [maka]
Posted by "faga295 (via GitHub)" <gi...@apache.org>.
faga295 commented on PR #4967:
URL: https://github.com/apache/maka/pull/4967#issuecomment-5578329734
This appears to be already fixed in the latest code, so I'm closing this PR. Thanks for taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop [maka]
Posted by "faga295 (via GitHub)" <gi...@apache.org>.
faga295 closed pull request #4967: fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop
URL: https://github.com/apache/maka/pull/4967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org