You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2024/10/09 09:43:31 UTC

[PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

morningman opened a new pull request, #41609:
URL: https://github.com/apache/doris/pull/41609

   Otherwise, if ping failed, some of required fields are not set, causing some unexpected error log like:
   ![img_v3_02ff_a120257d-1614-4e33-9b4a-1cbe33eb84dg](https://github.com/user-attachments/assets/0e933fab-b541-4b6a-ba95-264b282354c7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401951513

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.42 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 7f3c3c17cd8eda16776452eae6bb54bad77876a1, data reload: false
   
   query1	0.04	0.04	0.03
   query2	0.06	0.03	0.02
   query3	0.23	0.07	0.06
   query4	1.65	0.10	0.10
   query5	0.54	0.53	0.51
   query6	1.13	0.72	0.72
   query7	0.02	0.02	0.02
   query8	0.04	0.03	0.03
   query9	0.55	0.51	0.50
   query10	0.54	0.54	0.55
   query11	0.13	0.11	0.11
   query12	0.13	0.10	0.11
   query13	0.62	0.59	0.59
   query14	2.73	2.73	2.73
   query15	0.88	0.83	0.85
   query16	0.39	0.38	0.41
   query17	0.99	1.09	1.06
   query18	0.20	0.20	0.20
   query19	1.85	1.83	1.98
   query20	0.02	0.01	0.01
   query21	15.34	0.61	0.60
   query22	2.76	2.32	1.98
   query23	17.09	0.89	0.78
   query24	2.90	0.50	1.48
   query25	0.25	0.26	0.04
   query26	0.33	0.14	0.14
   query27	0.06	0.04	0.04
   query28	10.93	1.10	1.06
   query29	12.52	3.20	3.20
   query30	0.24	0.06	0.05
   query31	2.90	0.38	0.39
   query32	3.28	0.47	0.45
   query33	3.01	3.07	3.03
   query34	16.95	4.50	4.52
   query35	4.52	4.52	4.56
   query36	0.65	0.48	0.48
   query37	0.08	0.06	0.07
   query38	0.04	0.03	0.04
   query39	0.03	0.02	0.02
   query40	0.17	0.13	0.12
   query41	0.07	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.03	0.03	0.03
   Total cold run time: 106.92 s
   Total hot run time: 32.42 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401917537

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41064 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 7f3c3c17cd8eda16776452eae6bb54bad77876a1, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17578	7368	7496	7368
   q2	2017	278	268	268
   q3	12313	1045	1160	1045
   q4	10574	763	755	755
   q5	7768	2847	2802	2802
   q6	238	155	151	151
   q7	990	629	605	605
   q8	9357	1866	1882	1866
   q9	6695	6463	6419	6419
   q10	7007	2280	2322	2280
   q11	436	245	247	245
   q12	412	219	218	218
   q13	17770	2982	2998	2982
   q14	239	214	219	214
   q15	569	529	519	519
   q16	645	600	578	578
   q17	960	645	600	600
   q18	7214	6809	6741	6741
   q19	1349	1029	1024	1024
   q20	494	212	212	212
   q21	3937	3168	3337	3168
   q22	1101	1008	1004	1004
   Total cold run time: 109663 ms
   Total hot run time: 41064 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7277	7302	7276	7276
   q2	326	231	227	227
   q3	3067	2899	2959	2899
   q4	2147	1827	1794	1794
   q5	5751	5742	5771	5742
   q6	238	149	149	149
   q7	2241	1873	1875	1873
   q8	3388	3557	3809	3557
   q9	8909	8945	8840	8840
   q10	3599	3543	3525	3525
   q11	597	504	483	483
   q12	876	615	630	615
   q13	9668	3169	3204	3169
   q14	315	282	280	280
   q15	593	530	523	523
   q16	702	655	642	642
   q17	1860	1659	1628	1628
   q18	8182	7713	7423	7423
   q19	1737	1486	1533	1486
   q20	2130	1852	1899	1852
   q21	5440	5439	5404	5404
   q22	1129	1065	1073	1065
   Total cold run time: 70172 ms
   Total hot run time: 60452 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401948144

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401844023

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401844713

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401948092

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #41609:
URL: https://github.com/apache/doris/pull/41609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2406611313

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](heartbeat) fill default value for required field in TFrontendPingFrontendResult [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41609:
URL: https://github.com/apache/doris/pull/41609#issuecomment-2401941006

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192144 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 7f3c3c17cd8eda16776452eae6bb54bad77876a1, data reload: false
   
   query1	940	408	412	408
   query2	6254	2115	2081	2081
   query3	8691	192	202	192
   query4	34424	23585	23505	23505
   query5	3480	464	475	464
   query6	278	174	161	161
   query7	4201	301	315	301
   query8	287	239	218	218
   query9	9439	2699	2685	2685
   query10	451	272	265	265
   query11	17678	15129	15117	15117
   query12	157	110	99	99
   query13	1579	489	433	433
   query14	9093	7543	7595	7543
   query15	250	175	168	168
   query16	8017	476	492	476
   query17	1671	628	602	602
   query18	2149	325	328	325
   query19	378	157	156	156
   query20	122	115	114	114
   query21	208	102	114	102
   query22	4627	4508	4500	4500
   query23	34756	33961	33927	33927
   query24	11077	2851	2848	2848
   query25	630	417	398	398
   query26	1159	159	164	159
   query27	2587	298	309	298
   query28	7727	2438	2419	2419
   query29	843	441	431	431
   query30	256	153	150	150
   query31	1024	798	780	780
   query32	94	53	56	53
   query33	772	297	321	297
   query34	906	490	518	490
   query35	886	742	721	721
   query36	1083	953	951	951
   query37	150	89	85	85
   query38	4005	3924	3869	3869
   query39	1481	1405	1437	1405
   query40	212	99	104	99
   query41	49	45	47	45
   query42	117	99	99	99
   query43	527	498	470	470
   query44	1245	822	815	815
   query45	193	164	169	164
   query46	1151	732	727	727
   query47	1942	1876	1847	1847
   query48	434	369	345	345
   query49	921	410	397	397
   query50	845	402	415	402
   query51	7001	7113	6901	6901
   query52	101	85	93	85
   query53	257	184	181	181
   query54	1188	479	493	479
   query55	82	79	78	78
   query56	298	274	272	272
   query57	1279	1202	1155	1155
   query58	241	238	265	238
   query59	3293	3179	2903	2903
   query60	297	268	266	266
   query61	105	99	102	99
   query62	835	665	665	665
   query63	219	185	180	180
   query64	5041	660	626	626
   query65	3243	3179	3168	3168
   query66	1291	312	307	307
   query67	15961	15822	15558	15558
   query68	4416	571	568	568
   query69	481	289	303	289
   query70	1168	1116	1090	1090
   query71	351	275	281	275
   query72	7245	3968	3969	3968
   query73	763	348	350	348
   query74	9961	9015	8960	8960
   query75	3404	2713	2658	2658
   query76	2798	919	902	902
   query77	580	297	295	295
   query78	10535	9553	9546	9546
   query79	1472	587	591	587
   query80	1047	452	451	451
   query81	577	236	239	236
   query82	654	136	144	136
   query83	291	135	134	134
   query84	266	78	77	77
   query85	1662	311	301	301
   query86	407	296	267	267
   query87	4470	4315	4376	4315
   query88	3162	2448	2416	2416
   query89	410	292	286	286
   query90	1876	184	186	184
   query91	143	108	105	105
   query92	61	48	48	48
   query93	1516	546	540	540
   query94	981	300	283	283
   query95	362	254	259	254
   query96	613	281	280	280
   query97	3274	3097	3093	3093
   query98	212	202	196	196
   query99	1523	1298	1289	1289
   Total cold run time: 298859 ms
   Total hot run time: 192144 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org