[commons-geometry] 03/04: GEOMETRY-14: updates to QuaternionRotation based on changes in Quaternion from commons-numbers

[er...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch feature_GEOMETRY-14
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit d52d1d00672e39e67fd2278b0f9b65446fac5b10
Author: Matt Juntunen <ma...@hotmail.com>
AuthorDate: Fri Dec 14 07:53:13 2018 -0500

    GEOMETRY-14: updates to QuaternionRotation based on changes in Quaternion from commons-numbers
---
 .../commons/geometry/euclidean/threed/rotation/QuaternionRotation.java  | 2 +-
 .../geometry/euclidean/threed/rotation/QuaterionRotationTest.java       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java
index b19c53c..8330158 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaternionRotation.java
@@ -63,7 +63,7 @@ public final class QuaternionRotation implements Serializable {
     /** Instance used to represent the identity rotation, ie a rotation with
      * an angle of zero.
      */
-    private static final QuaternionRotation IDENTITY_INSTANCE = new QuaternionRotation(Quaternion.IDENTITY);
+    private static final QuaternionRotation IDENTITY_INSTANCE = of(1, 0, 0, 0);
 
     /** Unit-length quaternion instance in positive polar form. */
     private final Quaternion quat;
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaterionRotationTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaterionRotationTest.java
index a87d351..7308fc2 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaterionRotationTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/rotation/QuaterionRotationTest.java
@@ -504,7 +504,7 @@ public class QuaterionRotationTest {
 
         // assert
         Assert.assertTrue(q.getW() > 0);
-        Assert.assertTrue(q.getQuaternion().isUnitQuaternion(EPS));
+        Assert.assertEquals(1.0, q.getQuaternion().norm(), EPS);
 
         assertRotationEquals(StandardRotations.PLUS_DIAGONAL_TWO_THIRDS_PI, q);
     }