You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:49:06 UTC
[GitHub] [hbase] javierluca opened a new pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode
javierluca opened a new pull request #3054:
URL: https://github.com/apache/hbase/pull/3054
This is just a very minor improvement over https://github.com/apache/hbase/pull/2973 (that was actually pushed by @saintstack at https://github.com/apache/hbase/commit/59ec375d679dcbf1701a92d4206ecc676a8fb069).
However, I like the approach to use "localhost" as the argument hostname for the purpose instead of having to pass the fqdn itself, so I would like to add such option (see https://github.com/apache/hbase/pull/3048).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#issuecomment-800231894
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 2m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3054 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 6aca4e82b46a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d74ae15fa7 |
| Max. process+thread count | 49 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console |
| versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
javierluca commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r597387532
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
> Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true
Ah no, that is my mistake. Sorry about that, we should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#issuecomment-800232238
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 27s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 2m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3054 |
| Optional Tests | |
| uname | Linux b5673ef1a7de 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d74ae15fa7 |
| Max. process+thread count | 46 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
javierluca commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r595138244
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
From my understanding, passing "localhost" to `regionserver.sh` is meant to be used in pseudo-distributed environments. See:
- https://issues.apache.org/jira/browse/HBASE-15924?focusedCommentId=16410243&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16410243
- https://issues.apache.org/jira/browse/HBASE-20130
And it would use fixed ports:
https://github.com/apache/hbase/blob/d74ae15fa7a110d3e2b35bf53d8823ba0b1bb33b/bin/regionservers.sh#L61-L64
Since I want to avoid that, let me reassign hostname to the fqdn here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
javierluca commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r597387532
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
> Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true
Ah no, that is my mistake. Sorry about that, we should remove the first check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r595394923
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
Thanks @javierluca . Thanks for digging in here.
Thanks for turning-up the 'overloading' of 'localhost'.
Above looks reasonable. Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true: i.e. do we need lines #108-110 in above now you've added #111-114?
Lets open new issue for this further discussion so we don't muddle JIRA+PR intent.
Thanks.
##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
if [ "$localhostname" == "$hostname" ]; then
local=true
fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+ local=true
+ hostname=$localhostname
Review comment:
Oh, on the ports for regionservers.sh, I think its just lazyness that they are hardcoded. Can change that in another issue.... Use HBASE_RS_BASE_PORT and HBASE_RS_INFO_BASE_PORT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] saintstack merged pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #3054:
URL: https://github.com/apache/hbase/pull/3054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#issuecomment-800232070
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 13s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 2m 21s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3054 |
| Optional Tests | |
| uname | Linux e25aabdc729d 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d74ae15fa7 |
| Max. process+thread count | 51 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3054/1/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org