You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/22 22:29:06 UTC
Review Request 62517: Update to gradle 4.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62517/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Stephan Erb.
Repository: aurora
Description
-------
Here's release notes along the way:
https://docs.gradle.org/3.2/release-notes.html ([deprecated](https://docs.gradle.org/3.2/release-notes.html#the-left-shift-operator-on-the-task-interface) left shift operator)
https://docs.gradle.org/3.3/release-notes.html
https://docs.gradle.org/3.4/release-notes.html ([added](https://github.com/gradle/gradle/issues/824) jacoco coverage check task, replaces our `CoverageReportCheck.groovy`)
https://docs.gradle.org/3.5/release-notes.html
https://docs.gradle.org/4.0/release-notes.html
https://docs.gradle.org/4.1/release-notes.html (improved parallel test console output)
https://docs.gradle.org/4.2/release-notes.html
Several of the releases also report incremental build speed improvements (which i have not measured).
Diffs
-----
build.gradle 04673388a88019a7923601f0b20607f9701507c5
buildSrc/gradle.properties a7214d34a994cd73be537569f4a70f5a02eeff33
buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy da91f3962837617243daee416eac71e1ffeb3caf
gradle/wrapper/gradle-wrapper.properties b290cf6a769c238ee6c5f604cece46b92c3ca654
Diff: https://reviews.apache.org/r/62517/diff/1/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 62517: Update to gradle 4.2
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62517/#review186033
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 22, 2017, 10:29 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62517/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 10:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Here's release notes along the way:
>
> https://docs.gradle.org/3.2/release-notes.html ([deprecated](https://docs.gradle.org/3.2/release-notes.html#the-left-shift-operator-on-the-task-interface) left shift operator)
> https://docs.gradle.org/3.3/release-notes.html
> https://docs.gradle.org/3.4/release-notes.html ([added](https://github.com/gradle/gradle/issues/824) jacoco coverage check task, replaces our `CoverageReportCheck.groovy`)
> https://docs.gradle.org/3.5/release-notes.html
>
> https://docs.gradle.org/4.0/release-notes.html
> https://docs.gradle.org/4.1/release-notes.html (improved parallel test console output)
> https://docs.gradle.org/4.2/release-notes.html
>
> Several of the releases also report incremental build speed improvements (which i have not measured).
>
>
> Diffs
> -----
>
> build.gradle 04673388a88019a7923601f0b20607f9701507c5
> buildSrc/gradle.properties a7214d34a994cd73be537569f4a70f5a02eeff33
> buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy da91f3962837617243daee416eac71e1ffeb3caf
> gradle/wrapper/gradle-wrapper.properties b290cf6a769c238ee6c5f604cece46b92c3ca654
>
>
> Diff: https://reviews.apache.org/r/62517/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62517: Update to gradle 4.2
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62517/#review186032
-----------------------------------------------------------
Ship it!
Master (4137dd2) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 22, 2017, 3:29 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62517/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 3:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Here's release notes along the way:
>
> https://docs.gradle.org/3.2/release-notes.html ([deprecated](https://docs.gradle.org/3.2/release-notes.html#the-left-shift-operator-on-the-task-interface) left shift operator)
> https://docs.gradle.org/3.3/release-notes.html
> https://docs.gradle.org/3.4/release-notes.html ([added](https://github.com/gradle/gradle/issues/824) jacoco coverage check task, replaces our `CoverageReportCheck.groovy`)
> https://docs.gradle.org/3.5/release-notes.html
>
> https://docs.gradle.org/4.0/release-notes.html
> https://docs.gradle.org/4.1/release-notes.html (improved parallel test console output)
> https://docs.gradle.org/4.2/release-notes.html
>
> Several of the releases also report incremental build speed improvements (which i have not measured).
>
>
> Diffs
> -----
>
> build.gradle 04673388a88019a7923601f0b20607f9701507c5
> buildSrc/gradle.properties a7214d34a994cd73be537569f4a70f5a02eeff33
> buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy da91f3962837617243daee416eac71e1ffeb3caf
> gradle/wrapper/gradle-wrapper.properties b290cf6a769c238ee6c5f604cece46b92c3ca654
>
>
> Diff: https://reviews.apache.org/r/62517/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62517: Update to gradle 4.2
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62517/#review186049
-----------------------------------------------------------
Ship it!
Nice, thanks!
Please be aware: This will break the nightly packaging build so we have to fix it in a subsequent patch.
- Stephan Erb
On Sept. 23, 2017, 12:29 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62517/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2017, 12:29 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Here's release notes along the way:
>
> https://docs.gradle.org/3.2/release-notes.html ([deprecated](https://docs.gradle.org/3.2/release-notes.html#the-left-shift-operator-on-the-task-interface) left shift operator)
> https://docs.gradle.org/3.3/release-notes.html
> https://docs.gradle.org/3.4/release-notes.html ([added](https://github.com/gradle/gradle/issues/824) jacoco coverage check task, replaces our `CoverageReportCheck.groovy`)
> https://docs.gradle.org/3.5/release-notes.html
>
> https://docs.gradle.org/4.0/release-notes.html
> https://docs.gradle.org/4.1/release-notes.html (improved parallel test console output)
> https://docs.gradle.org/4.2/release-notes.html
>
> Several of the releases also report incremental build speed improvements (which i have not measured).
>
>
> Diffs
> -----
>
> build.gradle 04673388a88019a7923601f0b20607f9701507c5
> buildSrc/gradle.properties a7214d34a994cd73be537569f4a70f5a02eeff33
> buildSrc/src/main/groovy/org/apache/aurora/build/CoverageReportCheck.groovy da91f3962837617243daee416eac71e1ffeb3caf
> gradle/wrapper/gradle-wrapper.properties b290cf6a769c238ee6c5f604cece46b92c3ca654
>
>
> Diff: https://reviews.apache.org/r/62517/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>