You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/26 06:08:08 UTC

[GitHub] [commons-rng] arturobernalg commented on a change in pull request #85: Minor Changes:

arturobernalg commented on a change in pull request #85:
URL: https://github.com/apache/commons-rng/pull/85#discussion_r619996534



##########
File path: commons-rng-sampling/src/main/java/org/apache/commons/rng/sampling/distribution/ChengBetaSampler.java
##########
@@ -266,6 +266,7 @@ public double sample() {
                 // Compute Y and Z
                 final double y = u1 * u2;
                 final double z = u1 * y;
+                final double v1 = Math.log(u1) - Math.log1p(-u1);

Review comment:
       Maybe another name should be better, but it's monday and i'm not so creative




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org