[jira] [Commented] (HADOOP-9257) HADOOP-9241 changed DN's default DU interval to 1m instead of 10m accidentally

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564579#comment-13564579 ] 

Hadoop QA commented on HADOOP-9257:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12566798/HADOOP-9257.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2104//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2104//console

This message is automatically generated.
                
> HADOOP-9241 changed DN's default DU interval to 1m instead of 10m accidentally
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-9257
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9257
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.0.3-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>         Attachments: HADOOP-9257.patch
>
>
> Suresh caught this on HADOOP-9241:
> {quote}
> Even for trivial jiras, I suggest getting the code review done before committing the code. Such changes are easy and quick to review.
> In this patch, did DU interval become 1 minute instead of 10 minutes?
> {code}
> -    this(path, 600000L);
> -    //10 minutes default refresh interval
> +    this(path, conf.getLong(CommonConfigurationKeys.FS_DU_INTERVAL_KEY,
> +                CommonConfigurationKeys.FS_DU_INTERVAL_DEFAULT));
> +  /** See <a href="{@docRoot}/../core-default.html">core-default.xml</a> */
> +  public static final String  FS_DU_INTERVAL_KEY = "fs.du.interval";
> +  /** Default value for FS_DU_INTERVAL_KEY */
> +  public static final long    FS_DU_INTERVAL_DEFAULT = 60000;
> {code}
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira