You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/09/27 09:11:20 UTC
[GitHub] [james-project] jeantil opened a new pull request, #1211: [JAMES-3696] makes PulsarMailQueue tests more stable
jeantil opened a new pull request, #1211:
URL: https://github.com/apache/james-project/pull/1211
Previously to this patch, filter registration was going through a pulsar delivery even for non-distributed James. This meant tests that verify the filtering behavior had to wait for the message to be consumed back from the queue.
This lead us to introduce an artificial wait to ensure that the filter was correctly registered. Unfortunately, the delay was not always enough, especially on the CI which lead to flaky tests.
I propose to add a small optmization which registers the filter with the receiving instance synchronously before publishing it to pulsar.
This way, the wait time to filter registration can be much smaller.
Because the filter stage uses a set, adding the same filter multiple times should have a negligible impact on performances.
There was already a test in place that verifies that filters are distributed through the cluster `ensureThatDeletionApplyOnBrowsingBothInstancesWithTwoInstancesOfMailQueue`
relates to https://github.com/apache/james-project/pull/1206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #1211: [JAMES-3696] makes PulsarMailQueue tests more stable
Posted by GitBox <gi...@apache.org>.
jeantil commented on PR #1211:
URL: https://github.com/apache/james-project/pull/1211#issuecomment-1260468967
:green_apple: build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #1211: [JAMES-3696] makes PulsarMailQueue tests more stable
Posted by GitBox <gi...@apache.org>.
Arsnael merged PR #1211:
URL: https://github.com/apache/james-project/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org