You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/10 00:02:11 UTC

[GitHub] [incubator-gobblin] zxcware opened a new pull request #3122: [GOBBLIN-1283] Fix schema redefine from adding field properties into field schema

zxcware opened a new pull request #3122:
URL: https://github.com/apache/incubator-gobblin/pull/3122


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
       - https://issues.apache.org/jira/browse/GOBBLIN-1283
   
   
   ### Description
   - [x] Here are some details about my PR:
    - It looks like when a nested child schema is present and referenced multiple times in the main schema, calling `convertFieldToSchemaWithProps` it over the nested child schema will trigger schema redefine parse exception.
    - We found `AvroFlattener` will keep the schema properties. There is no need to copy them from field properties.
   
   ### Tests
   - [x] My PR uses the following unit tests:
    - The changes are covered by `HiveAvroORCQueryGeneratorTest`
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] asfgit closed pull request #3122: [GOBBLIN-1283] Fix schema redefine from adding field properties into field schema

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3122:
URL: https://github.com/apache/incubator-gobblin/pull/3122


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org