You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 23:50:51 UTC
[GitHub] [airflow] kaxil opened a new pull request #17798: Prepare release for Kubernetes Provider
kaxil opened a new pull request #17798:
URL: https://github.com/apache/airflow/pull/17798
https://github.com/apache/airflow/issues/17186 -- This has made the XCom functionality not work with KubernetesPodOperator, this has been fixed by https://github.com/apache/airflow/pull/17760 -- so we should get this out sooner rather than later as recently released Airflow 2.1.3 will pull in latest kubernetes provider when we run `pip install -U apache-airflow[cncf.kubernetes]`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904872262
Yup we will do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] evanhlavaty commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
evanhlavaty commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904885671
Thanks for the quick replies all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] evanhlavaty commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
evanhlavaty commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904852186
Will there be a rebuild/deploy of the 2.1.3 dockerhub images? I just pulled 2.1.3 image this morning and this fix was not included, leaving the KPO still broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904409464
We can also make an exception and manually update constraints to include the 2.0.2 cncf.kubernetes and rebuild image when it is released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904408950
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#discussion_r694850954
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,20 @@
Changelog
---------
+2.0.2
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Fix using XCom with ''KubernetesPodOperator'' (#17760)``
Review comment:
Yep. I will fix it (and we are likely going a bit different direction anyway - trying the towncrier soon).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904854629
Yes. Due to popularity of this one, once the voting completes and we release K8S provider, we will push new constraints and images including it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#issuecomment-904854629
Yes. Due to popularity of this one, once the voting completes and we release K8S provider, we will push new constraints and images including it for 2.1.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #17798:
URL: https://github.com/apache/airflow/pull/17798#discussion_r694793098
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,20 @@
Changelog
---------
+2.0.2
+.....
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Fix using XCom with ''KubernetesPodOperator'' (#17760)``
Review comment:
I guess the log is auto generated by script? It seems that the the code quotation char isn't parsed correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17798: Prepare release for Kubernetes Provider
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17798:
URL: https://github.com/apache/airflow/pull/17798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org