You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/27 02:37:21 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #30148: [SPARK-33244][SQL] Unify the code paths for spark.table and spark.read.table

HeartSaVioR commented on pull request #30148:
URL: https://github.com/apache/spark/pull/30148#issuecomment-716940007


   This effectively prevents `spark.read.table` to check for the mode - `spark.table` can be used on both batch and streaming, whereas `spark.read.table` shouldn't (we just didn't do the check this where we should do). I'm OK if we restrict `spark.table` to be used only for batch query(probably need to document as that may be breaking change), but if not, I don't think this change is valid.
   
   cc. @cloud-fan as I remember we had a related discussion in other PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org