You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/03 20:37:38 UTC
[GitHub] mkleint commented on a change in pull request #775: [NETBEANS-1074]
module review websvc.metro.lib
mkleint commented on a change in pull request #775: [NETBEANS-1074] module review websvc.metro.lib
URL: https://github.com/apache/incubator-netbeans/pull/775#discussion_r214753525
##########
File path: websvc.metro.lib/src/org/netbeans/modules/websvc/metro/lib/metro.xml
##########
@@ -36,13 +36,23 @@
</volume>
<volume>
<type>javadoc</type>
- <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/metro-1.4-doc.zip!/</resource>
+ <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/webservices-api-javadoc.jar!/</resource>
+ <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/webservices-extra-javadoc.jar!/</resource>
+ <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/webservices-extra-api-javadoc.jar!/</resource-->
+ <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/webservices-rt-javadoc.jar!/</resource>
+ <resource>jar:nbinst://org.netbeans.modules.websvc.metro.lib/docs/webservices-tools-javadoc.jar!/</resource>
</volume>
<properties>
<!-- please check with mkleint@netbeans.org before/after updating this or "classpath" section -->
<property>
<name>maven-dependencies</name>
- <value>org.glassfish.metro:webservices-rt:2.3:jar</value>
+ <value>
+ org.glassfish.metro:webservices-api:2.3.1:jar
+ org.glassfish.metro:webservices-extra:2.3.1:jar
+ org.glassfish.metro:webservices-extra-api:2.3.1:jar
+ org.glassfish.metro:webservices-rt:2.3.1:jar
+ org.glassfish.metro:webservices-tools:2.3.1:jar
+ </value>
Review comment:
lgtm, however i don't recall anymore why you should check with me on this one ;)
I suppose when added to a maven project, all dependencies are properly added to pom.xml and the project builds?
maybe as part of the PR, remove the reference to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists