You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/14 17:29:54 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #21469: fix: Supports form_data param in old Explore endpoint
michael-s-molina opened a new pull request, #21469:
URL: https://github.com/apache/superset/pull/21469
### SUMMARY
This PR improves the support for the `form_data` param in the old `/superset/explore` endpoint. Previously, the old endpoint only redirected the user to the new endpoint with the same original request parameters. Now, if `form_data` is present, the endpoint will persist that information in the cache and replace the parameter with `form_data_key`, the new supported format.
Example:
```
GET /superset/explore/?form_data=<object>
```
will be redirected to
```
GET /explore/?form_data_key=<key>
```
### TESTING INSTRUCTIONS
Check that GET requests to the old endpoint are correctly redirected to the new endpoint with the correct parameters.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #21469: fix: Supports form_data param in old Explore endpoint
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #21469:
URL: https://github.com/apache/superset/pull/21469#discussion_r971121480
##########
superset/views/core.py:
##########
@@ -736,6 +738,40 @@ def import_dashboards(self) -> FlaskResponse:
"superset/import_dashboards.html", databases=databases
)
+ def get_redirect_url(self) -> str:
+ """Assembles the redirect URL to the new endpoint. It also replaces
+ the form_data param with a form_data_key by saving the original content
+ to the cache layer.
+ """
+ redirect_url = request.url.replace("/superset/explore", "/explore")
+ form_data_key = None
+ request_form_data = request.args.get("form_data")
+ if request_form_data:
+ parsed_form_data = loads_request_json(request_form_data)
+ slice_id = parsed_form_data.get(
+ "slice_id", int(request.args.get("slice_id", 0))
+ )
+ datasource = parsed_form_data.get("datasource")
+ if datasource:
+ parts = datasource.split("__")
+ datasource_id = parts[0]
+ datasource_type = parts[1]
+ parameters = CommandParameters(
+ datasource_id=datasource_id,
+ datasource_type=datasource_type,
+ chart_id=slice_id,
+ form_data=request_form_data,
+ )
+ form_data_key = CreateFormDataCommand(parameters).run()
+ if form_data_key:
+ url = parse.urlparse(redirect_url)
+ query = parse.parse_qs(url.query)
+ query.pop("form_data")
+ query["form_data_key"] = [form_data_key]
Review Comment:
From [urllib.parse](https://docs.python.org/3/library/urllib.parse.html#urllib.parse.parse_qs)
> The dictionary keys are the unique query variable names and the values are lists of values for each name.
It's because most web frameworks allow multiple values to be associated with a single field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #21469: fix: Supports form_data param in old Explore endpoint
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #21469:
URL: https://github.com/apache/superset/pull/21469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21469: fix: Supports form_data param in old Explore endpoint
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21469:
URL: https://github.com/apache/superset/pull/21469#issuecomment-1247129257
# [Codecov](https://codecov.io/gh/apache/superset/pull/21469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21469](https://codecov.io/gh/apache/superset/pull/21469?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eec945e) into [master](https://codecov.io/gh/apache/superset/commit/59ca7861c0ec47a574c9f033a843ea1b726752f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59ca786) will **decrease** coverage by `11.45%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head eec945e differs from pull request most recent head 2bff584. Consider uploading reports for the commit 2bff584 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21469 +/- ##
===========================================
- Coverage 66.59% 55.14% -11.46%
===========================================
Files 1791 1791
Lines 68555 68578 +23
Branches 7319 7319
===========================================
- Hits 45654 37814 -7840
- Misses 21008 28871 +7863
Partials 1893 1893
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.93% <8.33%> (-0.04%)` | :arrow_down: |
| python | `57.67% <8.33%> (-23.72%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.04% <8.33%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `34.69% <8.33%> (-40.87%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-85.30%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-80.77%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `15.62% <0.00%> (-76.25%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `25.00% <0.00%> (-69.05%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `31.25% <0.00%> (-68.75%)` | :arrow_down: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `24.03% <0.00%> (-67.45%)` | :arrow_down: |
| ... and [282 more](https://codecov.io/gh/apache/superset/pull/21469/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on a diff in pull request #21469: fix: Supports form_data param in old Explore endpoint
Posted by GitBox <gi...@apache.org>.
john-bodley commented on code in PR #21469:
URL: https://github.com/apache/superset/pull/21469#discussion_r971109696
##########
superset/views/core.py:
##########
@@ -736,6 +738,40 @@ def import_dashboards(self) -> FlaskResponse:
"superset/import_dashboards.html", databases=databases
)
+ def get_redirect_url(self) -> str:
+ """Assembles the redirect URL to the new endpoint. It also replaces
+ the form_data param with a form_data_key by saving the original content
+ to the cache layer.
+ """
+ redirect_url = request.url.replace("/superset/explore", "/explore")
+ form_data_key = None
+ request_form_data = request.args.get("form_data")
+ if request_form_data:
+ parsed_form_data = loads_request_json(request_form_data)
+ slice_id = parsed_form_data.get(
+ "slice_id", int(request.args.get("slice_id", 0))
+ )
+ datasource = parsed_form_data.get("datasource")
+ if datasource:
+ parts = datasource.split("__")
Review Comment:
```suggestion
datasource_id, datasource_type = datasource.split("__")
```
##########
superset/views/core.py:
##########
@@ -736,6 +738,40 @@ def import_dashboards(self) -> FlaskResponse:
"superset/import_dashboards.html", databases=databases
)
+ def get_redirect_url(self) -> str:
+ """Assembles the redirect URL to the new endpoint. It also replaces
+ the form_data param with a form_data_key by saving the original content
+ to the cache layer.
+ """
+ redirect_url = request.url.replace("/superset/explore", "/explore")
+ form_data_key = None
+ request_form_data = request.args.get("form_data")
+ if request_form_data:
+ parsed_form_data = loads_request_json(request_form_data)
+ slice_id = parsed_form_data.get(
+ "slice_id", int(request.args.get("slice_id", 0))
+ )
+ datasource = parsed_form_data.get("datasource")
+ if datasource:
+ parts = datasource.split("__")
+ datasource_id = parts[0]
+ datasource_type = parts[1]
+ parameters = CommandParameters(
+ datasource_id=datasource_id,
+ datasource_type=datasource_type,
+ chart_id=slice_id,
+ form_data=request_form_data,
+ )
+ form_data_key = CreateFormDataCommand(parameters).run()
+ if form_data_key:
+ url = parse.urlparse(redirect_url)
+ query = parse.parse_qs(url.query)
+ query.pop("form_data")
+ query["form_data_key"] = [form_data_key]
Review Comment:
Why this this an array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org