[jira] [Commented] (IMPALA-9849) Set halt_on_error=1 for TSAN builds

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136201#comment-17136201 ] 

ASF subversion and git services commented on IMPALA-9849:
---------------------------------------------------------

Commit 38b96174621c7d2f58b580d1e2bba4b95b261d1c in impala's branch refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=38b9617 ]

IMPALA-9849: Set halt_on_error=1 for TSAN builds

Set halt_on_error to true by default for TSAN builds (we already do this
for ASAN builds). This ensures that Impala crashes whenever a TSAN error
is detected. IMPALA-9568 accidentally broke this.

Testing:
* Ran dataload + be tests in a TSAN build

Change-Id: I268c338d9194a66b37c3ccd97027e3543d27bea7
Reviewed-on: http://gerrit.cloudera.org:8080/16069
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Set halt_on_error=1 for TSAN builds
> -----------------------------------
>
>                 Key: IMPALA-9849
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9849
>             Project: IMPALA
>          Issue Type: Sub-task
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>
> IMPALA-9568 mistakingly removed the halt_on_error flag from TSAN builds. The intention in IMPALA-9568 was to make sure that Impala crashes when a TSAN bug is detected, Impala does this for ASAN builds already. The confusing part about halt_on_error is that by default it is true in ASAN builds, but by default it is false in TSAN builds. So halt_on_error needs to explicitly be set to true for TSAN builds (but not for ASAN builds).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org