You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/08/31 21:35:36 UTC

[kudu-CR] Fix RAT warnings 

Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7925

to review the following change.

Change subject: Fix RAT warnings
......................................................................

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7925/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Fix RAT warnings

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 4: Code-Review+2 Verified+1

(4 comments)

We discussed all of these changes yesterday and I think everyone's on board, so I'm going to go ahead in order to make progress on the release.

http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 16: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc
> Can remove this w/ the patch I posted
Done


Line 17: java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
> Same
We didn't author this file.


Line 30: python/README.md
> actually since this is from AsyncHBase I think we are already covered in li
Done


Line 175: www/epoch.0.5.2.min.css
> cool, this stuff is already there in LICENSE.txt
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/gradle-wrapper.properties:

Line 1
Per our chats, this is a generate file. I think Adar is fixing this.


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7925

to look at the new patch set (#4).

Change subject: Fix RAT warnings
......................................................................

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7925/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Fix RAT warnings

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7925/2/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 11: build-support/iwyu/iwyu_tool.py
This still needs a mention in LICENSE.txt


http://gerrit.cloudera.org:8080/#/c/7925/2/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/gradle-wrapper.properties:

PS2, Line 16: distributionBase=GRADLE_USER_HOME
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/gradle-wrapper.properties:

Line 1
deleted line


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 11: build-support/iwyu/iwyu_tool.py
may need to mention this in LICENSE.txt


Line 16: java/gradle.properties
Can remove this w/ the patch I posted


Line 17: java/gradle/wrapper/gradle-wrapper.properties
Same


Line 30: java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
we may need to mention this in LICENSE.txt


Line 175: www/bootstrap/css/bootstrap.min.css
cool, this stuff is already there in LICENSE.txt


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7925

to look at the new patch set (#3).

Change subject: Fix RAT warnings
......................................................................

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
M java/gradle/wrapper/gradle-wrapper.properties
3 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7925/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Fix RAT warnings

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.

Change subject: Fix RAT warnings
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 30: python/MANIFEST.in
> we may need to mention this in LICENSE.txt
actually since this is from AsyncHBase I think we are already covered in license.txt


-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Fix RAT warnings

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7925

to look at the new patch set (#2).

Change subject: Fix RAT warnings
......................................................................

Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
M java/gradle/wrapper/gradle-wrapper.properties
3 files changed, 24 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/7925/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] Fix RAT warnings

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: Fix RAT warnings
......................................................................


Fix RAT warnings

Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Reviewed-on: http://gerrit.cloudera.org:8080/7925
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M build-support/release/rat_exclude_files.txt
M java/gradle.properties
2 files changed, 7 insertions(+), 10 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0260ce9ce08790d3c6004dcdb0a78561691b5cbe
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>