You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@apache.org> on 2005/12/05 12:08:56 UTC

Cleaning up v2 - preparing a dispatcher release

Hi all,

how should we proceed for cleaning up v2?

I will soon commit a first working version of the DispatcherTransformer.
That means that 75% of the pipelines in structurer/themer will be gone.
I would like to use this opportunity and create the final internal
plugin (dispatcher) which should replace skins and old views (incl. v2).
I want to write this plugin from scratch (meaning to add pipeline by
pipeline). 

This plugin should contain the structurer and themer as components but
not anymore as 2 separate plugins. Further since the markup of contracts
have changed I want to use the opportunity to base the dispatcher
internally completely on xhtml2. Meaning all contracts are expecting
xhtml2 and *not* xdocs as source format.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: Cleaning up v2 - preparing a dispatcher release

Posted by Thorsten Scherler <th...@apache.org>.
El lun, 05-12-2005 a las 14:07 +0100, Cyriaque Dupoirieux escribió:
> Thorsten,
> 
> When will I have to change my *.fv and my contracts ?
> I mean, when will I have to update my :
>               <forrest:property name="nav-section-toc" nugget="get.tov">
>                 <jx:import 
> uri="cocoon://#{$cocoon/parameters/getRequest}.toc.xml"/>
>               </forrest:property>
> by the contract attribute :
>         dataURI="cocoon://#{$cocoon/parameters/getRequest}.toc.xml"

> And when will I have to use standalone contracts ?
> 

That is the point we need to discuss right now ;-) In theory we can
start to rewrite the whole plugins (themer/structurer) into one that can
do both. I removed lots of code by the move from v1 to v2, but now we
will have remove at least 75% or more. 

Having all said I am unsure whether I should start this work in v2 or in
a new plugin. The problem I see to do it in the v2 plugins, is that I
will 100% screw the plugins and you will not be able to use them anymore
(for a certain time).

There is one way to do it without major problems. We can use the
contract fallback mechanism. That means we just rewrite all contracts
and *.fv in the v2 template-site "locally" and not in the themer plugin.
This way it is possible to support both till we finished the rewrite. 

BTW I checked in a testing pipe (output.xmap), where you can test your
views and rewrite them (localhost:8888/test.*). One really good thing
coming with the move to java is the error handling. You will see and
know the difference. ;-)

> At the moment, I am waiting for you because you change so many things 
> that I don't want to investigate on such or such problem whereas you may 
> totally change the way it works.
> (That is I don't want to correct something like a pipeline or a 
> stylesheet whereas you are going to remove it ;-) )

Jeje, yeah I totally understand and thank you very much to sticking with
me all this refactoring time. It would be nice if you can give me
feedback to the localhost:8888/test.dispatcher. It is using 2 contracts
not more, but you will get the idea what changed (you did the pelt.fv,
so I am taking you as an expert).  ;-)

One open point is still the css linking. I have not come to write a
generic css-contract to get rid of forrest:css. That we need to do first
otherwise we can not move on.

Thanks for your feedback.

salu2

> 
> Salutations,
> Cyriaque,
> 
> *Cyri@que Dupoirieux* <ma...@pcotech.fr>
> ( 	Tél : 05.34.60.44.13 - Fax : 05.34.60.44.10
> Mobile : 06.30.29.17.07
> ------------------------------------------------------------------------
> + 	PCO Technologies <http://www.pcotech.fr>
> Burolines - 2 ter rue Marcel Doret
> 31700 Blagnac
> 
> 
> 
> 
> Thorsten Scherler a écrit :
> 
> >El lun, 05-12-2005 a las 12:08 +0100, Thorsten Scherler escribió:
> >  
> >
> >>Hi all,
> >>
> >>how should we proceed for cleaning up v2?
> >>
> >>I will soon commit a first working version of the DispatcherTransformer.
> >>That means that 75% of the pipelines in structurer/themer will be gone.
> >>I would like to use this opportunity and create the final internal
> >>plugin (dispatcher) which should replace skins and old views (incl. v2).
> >>I want to write this plugin from scratch (meaning to add pipeline by
> >>pipeline). 
> >>
> >>This plugin should contain the structurer and themer as components but
> >>not anymore as 2 separate plugins. Further since the markup of contracts
> >>have changed I want to use the opportunity to base the dispatcher
> >>internally completely on xhtml2. Meaning all contracts are expecting
> >>xhtml2 and *not* xdocs as source format.
> >>    
> >>
> >
> >In addition the dispatcher will use the new property system that Ross
> >used in some plugins. Meaning *all* dispatcher specific properties
> >should be removed from the
> >a) forrest.properties
> >b) forrest.core.xconf (2 step)
> >
> >salu2
> >  
> >
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: Cleaning up v2 - preparing a dispatcher release

Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
Thorsten,

When will I have to change my *.fv and my contracts ?
I mean, when will I have to update my :
              <forrest:property name="nav-section-toc" nugget="get.tov">
                <jx:import 
uri="cocoon://#{$cocoon/parameters/getRequest}.toc.xml"/>
              </forrest:property>
by the contract attribute :
        dataURI="cocoon://#{$cocoon/parameters/getRequest}.toc.xml"

And when will I have to use standalone contracts ?

At the moment, I am waiting for you because you change so many things 
that I don't want to investigate on such or such problem whereas you may 
totally change the way it works.
(That is I don't want to correct something like a pipeline or a 
stylesheet whereas you are going to remove it ;-) )

Salutations,
Cyriaque,

*Cyri@que Dupoirieux* <ma...@pcotech.fr>
( 	Tél : 05.34.60.44.13 - Fax : 05.34.60.44.10
Mobile : 06.30.29.17.07
------------------------------------------------------------------------
+ 	PCO Technologies <http://www.pcotech.fr>
Burolines - 2 ter rue Marcel Doret
31700 Blagnac




Thorsten Scherler a écrit :

>El lun, 05-12-2005 a las 12:08 +0100, Thorsten Scherler escribió:
>  
>
>>Hi all,
>>
>>how should we proceed for cleaning up v2?
>>
>>I will soon commit a first working version of the DispatcherTransformer.
>>That means that 75% of the pipelines in structurer/themer will be gone.
>>I would like to use this opportunity and create the final internal
>>plugin (dispatcher) which should replace skins and old views (incl. v2).
>>I want to write this plugin from scratch (meaning to add pipeline by
>>pipeline). 
>>
>>This plugin should contain the structurer and themer as components but
>>not anymore as 2 separate plugins. Further since the markup of contracts
>>have changed I want to use the opportunity to base the dispatcher
>>internally completely on xhtml2. Meaning all contracts are expecting
>>xhtml2 and *not* xdocs as source format.
>>    
>>
>
>In addition the dispatcher will use the new property system that Ross
>used in some plugins. Meaning *all* dispatcher specific properties
>should be removed from the
>a) forrest.properties
>b) forrest.core.xconf (2 step)
>
>salu2
>  
>

Re: Cleaning up v2 - preparing a dispatcher release

Posted by Thorsten Scherler <th...@apache.org>.
El lun, 05-12-2005 a las 12:08 +0100, Thorsten Scherler escribió:
> Hi all,
> 
> how should we proceed for cleaning up v2?
> 
> I will soon commit a first working version of the DispatcherTransformer.
> That means that 75% of the pipelines in structurer/themer will be gone.
> I would like to use this opportunity and create the final internal
> plugin (dispatcher) which should replace skins and old views (incl. v2).
> I want to write this plugin from scratch (meaning to add pipeline by
> pipeline). 
> 
> This plugin should contain the structurer and themer as components but
> not anymore as 2 separate plugins. Further since the markup of contracts
> have changed I want to use the opportunity to base the dispatcher
> internally completely on xhtml2. Meaning all contracts are expecting
> xhtml2 and *not* xdocs as source format.

In addition the dispatcher will use the new property system that Ross
used in some plugins. Meaning *all* dispatcher specific properties
should be removed from the
a) forrest.properties
b) forrest.core.xconf (2 step)

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: Using the xhtml2 plugin as final dispatcher plugin

Posted by Thorsten Scherler <th...@apache.org>.
El mar, 13-12-2005 a las 11:42 +1100, David Crossley escribió:
> Ross Gardler wrote:
> > Thorsten Scherler wrote:
> > >Tim Williams escribi??:
> > >>Thorsten Scherler wrote:
> > >>
> > >>>how should we proceed for cleaning up v2?
> > >>>
> > >>>I will soon commit a first working version of the DispatcherTransformer.
> > >>>That means that 75% of the pipelines in structurer/themer will be gone.
> > >>>I would like to use this opportunity and create the final internal
> > >>>plugin (dispatcher) which should replace skins and old views (incl. v2).
> > >>>I want to write this plugin from scratch (meaning to add pipeline by
> > >>>pipeline).
> > >>>
> > >>>This plugin should contain the structurer and themer as components but
> > >>>not anymore as 2 separate plugins. Further since the markup of contracts
> > >>>have changed I want to use the opportunity to base the dispatcher
> > >>>internally completely on xhtml2. Meaning all contracts are expecting
> > >>>xhtml2 and *not* xdocs as source format.
> > >>
> > >>So can we just clear out the xhtml2 plugin and use that?  That's
> > >>really what it was intended for Views+XHTML2 IIRC.  I think it's safe
> > >>to remove most everything in there except the xhtml2_subset.xml file. 
> > >>Everything else in there is OBE.
> > >>
> > >>I'd personally rather see that, rather than YAVRP (yet another
> > >>view-related plugin) ;)
> > >
> > >I agree with Tim and would start to 
> > >a) clean the xhtml2 from v1
> > >b) starting to add refactored structurer (*.fv) and contracts (*.ft) to
> > >the xhtml2 plugin
> > >c) removing v2 when finished the migration.
> > >
> > >wdyt?
> > 
> > Since you don't say it is lazy consensus...
> > 
> > +1
> 
> The default is lazy consensus. So just get on with the job
> unless someone asks to stop, review, perhaps revert.

Actually I had a look on the involved tasks and IMO it is easier to just
copy the xhtml2 specific stuff (documents, samples and stylesheet) to
the dispatcher then the other way around. 

I think it is better to "implode" the plugins, meaning to use v2 to
shrink and remove unneeded resources.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: Using the xhtml2 plugin as final dispatcher plugin

Posted by David Crossley <cr...@apache.org>.
Ross Gardler wrote:
> Thorsten Scherler wrote:
> >Tim Williams escribi??:
> >>Thorsten Scherler wrote:
> >>
> >>>how should we proceed for cleaning up v2?
> >>>
> >>>I will soon commit a first working version of the DispatcherTransformer.
> >>>That means that 75% of the pipelines in structurer/themer will be gone.
> >>>I would like to use this opportunity and create the final internal
> >>>plugin (dispatcher) which should replace skins and old views (incl. v2).
> >>>I want to write this plugin from scratch (meaning to add pipeline by
> >>>pipeline).
> >>>
> >>>This plugin should contain the structurer and themer as components but
> >>>not anymore as 2 separate plugins. Further since the markup of contracts
> >>>have changed I want to use the opportunity to base the dispatcher
> >>>internally completely on xhtml2. Meaning all contracts are expecting
> >>>xhtml2 and *not* xdocs as source format.
> >>
> >>So can we just clear out the xhtml2 plugin and use that?  That's
> >>really what it was intended for Views+XHTML2 IIRC.  I think it's safe
> >>to remove most everything in there except the xhtml2_subset.xml file. 
> >>Everything else in there is OBE.
> >>
> >>I'd personally rather see that, rather than YAVRP (yet another
> >>view-related plugin) ;)
> >
> >I agree with Tim and would start to 
> >a) clean the xhtml2 from v1
> >b) starting to add refactored structurer (*.fv) and contracts (*.ft) to
> >the xhtml2 plugin
> >c) removing v2 when finished the migration.
> >
> >wdyt?
> 
> Since you don't say it is lazy consensus...
> 
> +1

The default is lazy consensus. So just get on with the job
unless someone asks to stop, review, perhaps revert.

-David

Re: Using the xhtml2 plugin as final dispatcher plugin (was Re: Cleaning up v2 - preparing a dispatcher release)

Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> El lun, 05-12-2005 a las 16:19 -0500, Tim Williams escribió:
> 
>>On 12/5/05, Thorsten Scherler <th...@apache.org> wrote:
>>
>>>Hi all,
>>>
>>>how should we proceed for cleaning up v2?
>>>
>>>I will soon commit a first working version of the DispatcherTransformer.
>>>That means that 75% of the pipelines in structurer/themer will be gone.
>>>I would like to use this opportunity and create the final internal
>>>plugin (dispatcher) which should replace skins and old views (incl. v2).
>>>I want to write this plugin from scratch (meaning to add pipeline by
>>>pipeline).
>>>
>>>This plugin should contain the structurer and themer as components but
>>>not anymore as 2 separate plugins. Further since the markup of contracts
>>>have changed I want to use the opportunity to base the dispatcher
>>>internally completely on xhtml2. Meaning all contracts are expecting
>>>xhtml2 and *not* xdocs as source format.
>>
>>So can we just clear out the xhtml2 plugin and use that?  That's
>>really what it was intended for Views+XHTML2 IIRC.  I think it's safe
>>to remove most everything in there except the xhtml2_subset.xml file. 
>>Everything else in there is OBE.
>>
>>I'd personally rather see that, rather than YAVRP (yet another
>>view-related plugin) ;)
>>--tim
> 
> 
> I agree with Tim and would start to 
> a) clean the xhtml2 from v1
> b) starting to add refactored structurer (*.fv) and contracts (*.ft) to
> the xhtml2 plugin
> c) removing v2 when finished the migration.
> 
> wdyt?

Since you don't say it is lazy consensus...

+1

Ross


Using the xhtml2 plugin as final dispatcher plugin (was Re: Cleaning up v2 - preparing a dispatcher release)

Posted by Thorsten Scherler <th...@apache.org>.
El lun, 05-12-2005 a las 16:19 -0500, Tim Williams escribió:
> On 12/5/05, Thorsten Scherler <th...@apache.org> wrote:
> > Hi all,
> >
> > how should we proceed for cleaning up v2?
> >
> > I will soon commit a first working version of the DispatcherTransformer.
> > That means that 75% of the pipelines in structurer/themer will be gone.
> > I would like to use this opportunity and create the final internal
> > plugin (dispatcher) which should replace skins and old views (incl. v2).
> > I want to write this plugin from scratch (meaning to add pipeline by
> > pipeline).
> >
> > This plugin should contain the structurer and themer as components but
> > not anymore as 2 separate plugins. Further since the markup of contracts
> > have changed I want to use the opportunity to base the dispatcher
> > internally completely on xhtml2. Meaning all contracts are expecting
> > xhtml2 and *not* xdocs as source format.
> 
> So can we just clear out the xhtml2 plugin and use that?  That's
> really what it was intended for Views+XHTML2 IIRC.  I think it's safe
> to remove most everything in there except the xhtml2_subset.xml file. 
> Everything else in there is OBE.
> 
> I'd personally rather see that, rather than YAVRP (yet another
> view-related plugin) ;)
> --tim

I agree with Tim and would start to 
a) clean the xhtml2 from v1
b) starting to add refactored structurer (*.fv) and contracts (*.ft) to
the xhtml2 plugin
c) removing v2 when finished the migration.

wdyt?

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: Cleaning up v2 - preparing a dispatcher release

Posted by Tim Williams <wi...@gmail.com>.
On 12/5/05, Thorsten Scherler <th...@apache.org> wrote:
> Hi all,
>
> how should we proceed for cleaning up v2?
>
> I will soon commit a first working version of the DispatcherTransformer.
> That means that 75% of the pipelines in structurer/themer will be gone.
> I would like to use this opportunity and create the final internal
> plugin (dispatcher) which should replace skins and old views (incl. v2).
> I want to write this plugin from scratch (meaning to add pipeline by
> pipeline).
>
> This plugin should contain the structurer and themer as components but
> not anymore as 2 separate plugins. Further since the markup of contracts
> have changed I want to use the opportunity to base the dispatcher
> internally completely on xhtml2. Meaning all contracts are expecting
> xhtml2 and *not* xdocs as source format.

So can we just clear out the xhtml2 plugin and use that?  That's
really what it was intended for Views+XHTML2 IIRC.  I think it's safe
to remove most everything in there except the xhtml2_subset.xml file. 
Everything else in there is OBE.

I'd personally rather see that, rather than YAVRP (yet another
view-related plugin) ;)
--tim