You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/08/21 19:27:35 UTC
[GitHub] storm pull request #2288: [STORM-2700] Should not check Blobstore ACL if the...
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2288
[STORM-2700] Should not check Blobstore ACL if the validation is disabled
See: https://issues.apache.org/jira/browse/STORM-2700
`canUserReadBlob ` function should take `STORM_BLOBSTORE_ACL_VALIDATION_ENABLED` config into consideration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm STORM-2700
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2288
----
commit d1b73321399658693ba31fa533079615cb2c6cd9
Author: Ethan Li <et...@gmail.com>
Date: 2017-08-21T19:08:29Z
[STORM-2700] Should not check Blobstore ACL if the validation is disabled
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2288: [STORM-2700] Should not check Blobstore ACL if the valida...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2288
First of all, the change looks good.
Btw, the default value of `storm.blobstore.acl.validation.enabled` is `false` so it will affect all of the existing cluster. Moreover I don't think it is good default value for secure cluster. Maybe we should explore to change the default value to `true` and see it also works with insecure cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2288: [STORM-2700] Should not check Blobstore ACL if the valida...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2288
@HeartSaVioR I agree that it should not be false by default for a secure cluster. But like @Ethanlm said it is not a simple task to make part of security work on an insecure cluster. The other alternative is to have a way to automatically determine if the cluster is secure or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2288: [STORM-2700] Should not check Blobstore ACL if the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2288: [STORM-2700] Should not check Blobstore ACL if the valida...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2288
This error should be unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2288: [STORM-2700] Should not check Blobstore ACL if the valida...
Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2288
@HeartSaVioR Yes. But changing default value seems not very simple. We probably need to file another JIRA for it if we want to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---