[jira] [Commented] (AIRFLOW-5428) Dataflow with one job is not done correctly

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924421#comment-16924421 ] 

ASF GitHub Bot commented on AIRFLOW-5428:
-----------------------------------------

mik-laj commented on pull request #6036: [AIRFLOW-5428][WIP] Dataflow with one job is not done correctly
URL: https://github.com/apache/airflow/pull/6036
 
 
   Details information is available here: https://github.com/apache/airflow/pull/4633#discussion_r321568473
   ```
   [2019-09-06 03:20:51,974] {taskinstance.py:1042} ERROR - string indices must be integers
   Traceback (most recent call last):
     File "/opt/airflow/airflow/models/taskinstance.py", line 917, in _run_raw_task
       result = task_copy.execute(context=context)
     File "/opt/airflow/airflow/gcp/operators/dataflow.py", line 216, in execute
       self.jar, self.job_class, True, self.multiple_jobs)
     File "/opt/airflow/airflow/gcp/hooks/dataflow.py", line 372, in start_java_dataflow
       self._start_dataflow(variables, name, command_prefix, label_formatter, multiple_jobs)
     File "/opt/airflow/airflow/contrib/hooks/gcp_api_base_hook.py", line 307, in wrapper
       return func(self, *args, **kwargs)
     File "/opt/airflow/airflow/gcp/hooks/dataflow.py", line 327, in _start_dataflow
       variables['region'], self.poll_sleep, job_id, self.num_retries, multiple_jobs) \
     File "/opt/airflow/airflow/gcp/hooks/dataflow.py", line 76, in __init__
       self._jobs = self._get_jobs()
     File "/opt/airflow/airflow/gcp/hooks/dataflow.py", line 138, in _get_jobs
       self._job_id, job['name']
   TypeError: string indices must be integers
   ```
   CC: @Fokko  You've recently been reviewing the changes that introduced these regressions. Could you check if I missed something?
   
   I would like to test it  using system tests. Unfortunately, they are not finished yet, but I work hard on them - https://github.com/apache/airflow/pull/6035. When I confirm that the code works in all case, this change can be merge.
   
   ---
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Dataflow with one job is not done correctly
> -------------------------------------------
>
>                 Key: AIRFLOW-5428
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5428
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>    Affects Versions: 1.10.5
>            Reporter: Kamil Bregula
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)