You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2024/07/13 15:03:13 UTC
[PR] riscv: Only try to decode compressed instruction in misalign handler if it's enabled [nuttx]
no1wudi opened a new pull request, #12684:
URL: https://github.com/apache/nuttx/pull/12684
## Summary
riscv: Only try to decode compressed instruction in misalign handler if it's enabled
## Impact
Minor
## Testing
CI and local machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] riscv: Only try to decode compressed instruction in misalign handler if it's enabled [nuttx]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #12684:
URL: https://github.com/apache/nuttx/pull/12684#issuecomment-2227042791
Can be solved multiple ways including
```
#ifdef CONFIG_ARCH_RV_ISA_C
static bool decode_insn_compressed(uintptr_t *regs, riscv_insn_ctx_t *ctx)
{
...
}
#else
# define decode_insn_compressed(regs, ctx) false
#endif
```
and keeping dispatching loop.
I'm fine with @acassis 's suggestion, but just want to have PR description and commit message to reflect the actual change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] riscv: Only try to decode compressed instruction in misalign handler if it's enabled [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12684:
URL: https://github.com/apache/nuttx/pull/12684#issuecomment-2227034102
@no1wudi @pkarashchenko suggestion: remove the CONFIG_ARCH_RV_ISA_C from inside decode_insn_compressed() and keep this modifications since is it more clean and makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] riscv: Only try to decode compressed instruction in misalign handler if it's enabled [nuttx]
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi closed pull request #12684: riscv: Only try to decode compressed instruction in misalign handler if it's enabled
URL: https://github.com/apache/nuttx/pull/12684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] riscv: Only try to decode compressed instruction in misalign handler if it's enabled [nuttx]
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on PR #12684:
URL: https://github.com/apache/nuttx/pull/12684#issuecomment-2227032056
PR does not bring any value since three is `#ifdef CONFIG_ARCH_RV_ISA_C` already inside the `decode_insn_compressed()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org