You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/10/08 01:50:44 UTC

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

Hello Mahesh Reddy, Tidy Bot, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18877

to look at the new patch set (#19).

Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy
......................................................................

[client] Fix a kudu c++ client bug when using replica_selection policy

At c++ client side, the replica_selection policy (LEADER_ONLY and
CLOSEST_REPLICA) is not working. Eg command: 'kudu perf table_scan
$master_list $table -columns=id,name -num_threads=4 -nofill_cache
-replica_selection="LEADER"', but the real replica_selection policy
is CLOSEST_REPLICA.

The patch fixes the bug in client library and adds unit tests.

Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2
---
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/common/common.proto
M src/kudu/tools/table_scanner.cc
M src/kudu/util/test_util.h
5 files changed, 283 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/18877/19
-- 
To view, visit http://gerrit.cloudera.org:8080/18877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I413f99b6a0b6082c5453358b8333913e4c6264c2
Gerrit-Change-Number: 18877
Gerrit-PatchSet: 19
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>