You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 17:13:22 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #15858: Enforce js linting for current ui in pre-commit
bbovenzi opened a new pull request #15858:
URL: https://github.com/apache/airflow/pull/15858
Add a new pre-commit hook to lint javascript in `airflow/www/static/js/` using ESLint.
To get linting to pass this PR also fixes all linting errors (there are still warnings, but they don't cause the hook to fail). Also, the rule `no-param-reassign` was changed to a warning instead of error because it would require major refactoring of all d3 implementations
Closes #14154
Since there are so many changes, we probably do not want this to be part of 2.1.0
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #15858: Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-848093249
@ashb looks like it's all passing again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15858: [WIP] 🚧 Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-841810922
Nice one. Agree we should wait :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #15858: Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #15858:
URL: https://github.com/apache/airflow/pull/15858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15858: [WIP] 🚧 Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-841433654
[The Workflow run](https://github.com/apache/airflow/actions/runs/842883399) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15858: [WIP] 🚧 Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-841810922
Nice one. Agree we should wait :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #15858: Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-847042237
@ashb rebased. Do you want to restart the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15858: Enforce js linting for current ui in pre-commit
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15858:
URL: https://github.com/apache/airflow/pull/15858#issuecomment-845103369
@bbovenzi Could you rebase please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org