You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 10:50:03 UTC

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #27886: Explicitly name the primary keys in ORM for task & dagrun notes table

ephraimbuddy commented on code in PR #27886:
URL: https://github.com/apache/airflow/pull/27886#discussion_r1031367908


##########
airflow/models/dagrun.py:
##########
@@ -1314,7 +1314,7 @@ class DagRunNote(Base):
     __tablename__ = "dag_run_note"
 
     user_id = Column(Integer, nullable=True)
-    dag_run_id = Column(Integer, primary_key=True, nullable=False)
+    dag_run_id = Column(Integer, primary_key=True, name="dag_run_note_pkey", nullable=False)

Review Comment:
   It works. Unless you have a composite key then it does not work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org