You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2011/07/07 06:05:16 UTC
[jira] [Created] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
-------------------------------------------------------------------------------
Key: HBASE-4072
URL: https://issues.apache.org/jira/browse/HBASE-4072
Project: HBase
Issue Type: Bug
Reporter: stack
This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support
for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4072:
---------------------------
Attachment: HBASE-4072.patch
Patch that does the following:
# Deprecates the ZKConfig#parseZooCfg method.
# Adds a new property that toggles zoo.cfg parsing. Property is named "hbase.config.read.zookeeper.config", and is false by default (i.e. we will no longer read zoo.cfg unless this has been manually enabled)
# Miscellaneous doc and log improvements in the same files to reflect this change.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414732#comment-13414732 ]
Harsh J commented on HBASE-4072:
--------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
I assembled a package, ran a single node cluster with hbase-site.xml configured and a zoo.cfg on the conf/ directory, pointing to a non-existent server. It seemed to start, which probably meant it picked up the hbase-site.xml and ignored zoo.cfg as my patch intends to. But I can add some tests, ideas?
bq. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
The additional javac warning is cause of the newly deprecated method being used (in the fallback method). I could suppress it, but dunno if thats good to do (we should be removing usage of that method by the next release after the one this goes into).
bq. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
In the report, none of the classes I've touched here seem to be reported.
{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
{quote}
The failing test passes for me on both trunk and with patch applied:
{code}
Running org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.11 sec
{code}
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446181#comment-13446181 ]
Jonathan Hsieh commented on HBASE-4072:
---------------------------------------
I believe it still is. We "fixed" this problem with a workaround in CDH but last I check trunk still looks at zoo.cfg.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202558#comment-13202558 ]
Jean-Daniel Cryans commented on HBASE-4072:
-------------------------------------------
Personally that wouldn't bother me, but maybe it will break a few installs.
> zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
> -------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508391#comment-13508391 ]
Hadoop QA commented on HBASE-4072:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555662/HBASE-4072.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 26 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3430//console
This message is automatically generated.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch, HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support
for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4072:
---------------------------
Attachment: HBASE-4072.patch
Sorry on the delay.
New patch with a proper test that addresses Jon's comment.
Can we target this JIRA for 0.96? I'm willing to commit to doing this for that release.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch, HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
Posted by "Karthik K (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202598#comment-13202598 ]
Karthik K commented on HBASE-4072:
----------------------------------
Agree with J-D here. I would vote for a deprecation message, before removing it altogether.
> zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
> -------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415679#comment-13415679 ]
Jonathan Hsieh commented on HBASE-4072:
---------------------------------------
Code looks good. Adding a test for this should be straightforwards -- have two different HBaseConfigurations (one with the new setting true and one with the new setting false), the check the properties. If the zoo.cfg file is not present and there are no zk settings we end up returning defaults.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned HBASE-4072:
------------------------------
Assignee: Harsh J
> zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
> -------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Harsh J
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support
for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4072:
---------------------------
Affects Version/s: 0.90.0
Release Note:
The Apache ZooKeeper config file zoo.cfg will no longer be read when instantiating a HBaseConfiguration object, as it causes various inconsistency issues. Instead, users have to specify all HBase-relevant ZooKeeper properties in the hbase-site.xml using the various "hbase.zookeeper" prefixed properties. For example, specify "hbase.zookeeper.quorum" to provide a ZK quorum server list.
To enable zoo.cfg reading, for which support may be removed in a future release, set the property "hbase.config.read.zookeeper.config" to true in the hbase-site.xml at the client/server.
Hadoop Flags: Incompatible change
Status: Patch Available (was: Open)
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443547#comment-13443547 ]
Lars Hofhansl commented on HBASE-4072:
--------------------------------------
Is this still an issue? I seem to recall that this was fixed a while ago.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) Deprecate/disable and remove
support for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414725#comment-13414725 ]
Hadoop QA commented on HBASE-4072:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12536563/HBASE-4072.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2389//console
This message is automatically generated.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: stack
> Assignee: Harsh J
> Attachments: HBASE-4072.patch
>
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4072) Deprecate/disable and remove support
for reading ZooKeeper zoo.cfg files from the classpath
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-4072:
---------------------------
Summary: Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath (was: zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes)
Retitling to reflect current approach.
> Deprecate/disable and remove support for reading ZooKeeper zoo.cfg files from the classpath
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Harsh J
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202982#comment-13202982 ]
Jonathan Hsieh commented on HBASE-4072:
---------------------------------------
Added some links to related issues.
> zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
> -------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4072) zoo.cfg inconsistently used and
sometimes we use non-zk names for zk attributes
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202368#comment-13202368 ]
Harsh J commented on HBASE-4072:
--------------------------------
Given that HBase does have its own zk config parts, should we just drop out zoo.cfg read support? Its bought in more problems than a solution.
> zoo.cfg inconsistently used and sometimes we use non-zk names for zk attributes
> -------------------------------------------------------------------------------
>
> Key: HBASE-4072
> URL: https://issues.apache.org/jira/browse/HBASE-4072
> Project: HBase
> Issue Type: Bug
> Reporter: stack
>
> This issue was found by Lars: http://search-hadoop.com/m/n04sthNcji2/zoo.cfg+vs+hbase-site.xml&subj=Re+zoo+cfg+vs+hbase+site+xml
> Lets fix the inconsistency found and fix the places where we use non-zk attribute name for a zk attribute in hbase (There's only a few places that I remember -- maximum client connections is one IIRC)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira