You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Paul Davis <pa...@gmail.com> on 2015/03/24 01:12:53 UTC
Closing old PRs
Hi all,
I've been going through trying to review open PRs today (long overdue, I
know) and I've noticed that there seem to be a lot of "open" PRs that have
actually been merged. Did we ever find a way to be able to close PRs
wihtout having to add a commit with the "Fixes #whatever" magic?
Paul
Re: Closing old PRs
Posted by Andy Wenk <an...@apache.org>.
ah ok - got it. Thanks ;-)
On 24 March 2015 at 10:24, Alexander Shorin <kx...@gmail.com> wrote:
> On Tue, Mar 24, 2015 at 12:19 PM, Andy Wenk <an...@apache.org> wrote:
> > just out of curiosity Alex, what exactly in this string will close the
> > ticket:
> >
> > "This closes #42"
> >
> > All the words? Or just #42 ?
>
> When PR is open, on dev@ comes a notification that contains the words
> like:
>
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> > This closes #303
> >
>
>
> --
> ,,,^..^,,,
>
--
Andy Wenk
Hamburg - Germany
RockIt!
GPG fingerprint: C044 8322 9E12 1483 4FEC 9452 B65D 6BE3 9ED3 9588
https://people.apache.org/keys/committer/andywenk.asc
Re: Closing old PRs
Posted by Alexander Shorin <kx...@gmail.com>.
On Tue, Mar 24, 2015 at 12:19 PM, Andy Wenk <an...@apache.org> wrote:
> just out of curiosity Alex, what exactly in this string will close the
> ticket:
>
> "This closes #42"
>
> All the words? Or just #42 ?
When PR is open, on dev@ comes a notification that contains the words like:
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #303
>
--
,,,^..^,,,
Re: Closing old PRs
Posted by Andy Wenk <an...@apache.org>.
just out of curiosity Alex, what exactly in this string will close the
ticket:
"This closes #42"
All the words? Or just #42 ?
Thanks ;-)
On 24 March 2015 at 09:04, Alexander Shorin <kx...@gmail.com> wrote:
> There are the following ways to automatically close PRs:
> 1. Add "This closes #42" to commit message
> 2. Explicit merge of PR'ed branch
> 3. When sha's of commits on master equals sha's PR commits (e.g. merge
> via rebase)
>
> In any other cases we need to ask an author to close his PR manually.
> --
> ,,,^..^,,,
>
>
> On Tue, Mar 24, 2015 at 10:35 AM, Andy Wenk <an...@nms.de> wrote:
> > Although it is a lot of work to go through all the PRs one way is to ask
> > the submitter to close the PR. If not done after say a week, simply close
> > it. Not sure if this can be done without this #magic at github ...
> > On Mar 24, 2015 1:14 AM, "Paul Davis" <pa...@gmail.com>
> wrote:
> >
> >> Hi all,
> >>
> >> I've been going through trying to review open PRs today (long overdue, I
> >> know) and I've noticed that there seem to be a lot of "open" PRs that
> have
> >> actually been merged. Did we ever find a way to be able to close PRs
> >> wihtout having to add a commit with the "Fixes #whatever" magic?
> >>
> >> Paul
> >>
>
--
Andy Wenk
Hamburg - Germany
RockIt!
GPG fingerprint: C044 8322 9E12 1483 4FEC 9452 B65D 6BE3 9ED3 9588
https://people.apache.org/keys/committer/andywenk.asc
Re: Closing old PRs
Posted by Alexander Shorin <kx...@gmail.com>.
There are the following ways to automatically close PRs:
1. Add "This closes #42" to commit message
2. Explicit merge of PR'ed branch
3. When sha's of commits on master equals sha's PR commits (e.g. merge
via rebase)
In any other cases we need to ask an author to close his PR manually.
--
,,,^..^,,,
On Tue, Mar 24, 2015 at 10:35 AM, Andy Wenk <an...@nms.de> wrote:
> Although it is a lot of work to go through all the PRs one way is to ask
> the submitter to close the PR. If not done after say a week, simply close
> it. Not sure if this can be done without this #magic at github ...
> On Mar 24, 2015 1:14 AM, "Paul Davis" <pa...@gmail.com> wrote:
>
>> Hi all,
>>
>> I've been going through trying to review open PRs today (long overdue, I
>> know) and I've noticed that there seem to be a lot of "open" PRs that have
>> actually been merged. Did we ever find a way to be able to close PRs
>> wihtout having to add a commit with the "Fixes #whatever" magic?
>>
>> Paul
>>
Re: Closing old PRs
Posted by Andy Wenk <an...@nms.de>.
Although it is a lot of work to go through all the PRs one way is to ask
the submitter to close the PR. If not done after say a week, simply close
it. Not sure if this can be done without this #magic at github ...
On Mar 24, 2015 1:14 AM, "Paul Davis" <pa...@gmail.com> wrote:
> Hi all,
>
> I've been going through trying to review open PRs today (long overdue, I
> know) and I've noticed that there seem to be a lot of "open" PRs that have
> actually been merged. Did we ever find a way to be able to close PRs
> wihtout having to add a commit with the "Fixes #whatever" magic?
>
> Paul
>