[GitHub] [airflow] potiuk commented on issue #5850: [AIRFLOW-1498] Add analytics script

[GitBox <gi...@apache.org>]

potiuk commented on issue #5850: [AIRFLOW-1498] Add analytics script
URL: https://github.com/apache/airflow/pull/5850#issuecomment-522802527
 
 
   Hey @ryw  -> I am going to add a `--show-diff-on-failure` flag shortly to show more details about the failure so that it will be obvious. Sorry for any inconvenience.
   
   In the meantime you can run 'pre-commit run insert-license` (see https://github.com/apache/airflow/blob/master/CONTRIBUTING.md#pre-commit-hooks-installed) - it's not yet 100% clear in the master docs but some more instructions are coming.
   
   The .pre-commit-confg.yaml does have the section:
   
   ```
         - id: insert-license
           name: Add licence for all rst files
           exclude: ^\.github/.*$"|^airflow/_vendor/.*$
           args:
             - --comment-style
             - "||"
             - --license-filepath
             - license-templates/LICENSE.rst
           files: \.rst$
   ```
   
   In this case it's probably spacing issue. Due to limitation of insert-license pre-commit we have to have a space in front of the .. in the .rst license. This has been changed recently in all the files while I committed the change so you probably took the license from previous (no-space-in-front) version. You can take a look at any of the .rst files now in master and copy&paste the license from there. This is what most people will do in the future I guess, so this will not be a problem. 
   
   And BTW if you install pre-commit hooks yourself, you will not need to worry about the licences at all.  When you try to commit the file without the license, the license will be added for you, commit will fail and you will have a chance to add/commit the added licence immediately.
   
   So you can just remove the licence now, install pre-commit, try to commit it and the licence will be added for you automagically.
   
   Sorry for the inconvenience coming from the transition period.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services