You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/10 18:57:29 UTC
[GitHub] [superset] nytai opened a new pull request #13557: fix(dashboard|chart): use correct url for favorite_status and change …
nytai opened a new pull request #13557:
URL: https://github.com/apache/superset/pull/13557
…request type to rison
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13557: fix(dashboard|chart): use correct url for favorite_status and change …
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13557:
URL: https://github.com/apache/superset/pull/13557#issuecomment-796043317
# [Codecov](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=h1) Report
> Merging [#13557](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=desc) (d5081bd) into [master](https://codecov.io/gh/apache/superset/commit/b9884fb55bdf40cc7f073d2b758f43a5b6265d6c?el=desc) (b9884fb) will **decrease** coverage by `3.97%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13557 +/- ##
==========================================
- Coverage 77.53% 73.56% -3.98%
==========================================
Files 904 603 -301
Lines 45987 21402 -24585
Branches 5552 5639 +87
==========================================
- Hits 35657 15744 -19913
+ Misses 10196 5524 -4672
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.20% <100.00%> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.38% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `60.62% <100.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | | |
| [superset/queries/saved\_queries/dao.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2Rhby5weQ==) | | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | | |
| [superset/reports/commands/alert.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
| [superset/annotation\_layers/filters.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvZmlsdGVycy5weQ==) | | |
| [superset/models/tags.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | | |
| [superset/reports/api.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | | |
| ... and [293 more](https://codecov.io/gh/apache/superset/pull/13557/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=footer). Last update [b9884fb...bd03ace](https://codecov.io/gh/apache/superset/pull/13557?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13557: fix(dashboard|chart): use correct url for favorite_status and change …
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13557:
URL: https://github.com/apache/superset/pull/13557#issuecomment-799576901
Is it possible (or correct) to configure the redirect to use relative path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #13557: fix(dashboard|chart): use correct url for favorite_status and change …
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #13557:
URL: https://github.com/apache/superset/pull/13557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org