You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2026/09/21 11:54:21 UTC

[PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

blaginin opened a new pull request, #11153:
URL: https://github.com/apache/arrow-rs/pull/11153

   re https://github.com/apache/arrow-rs/pull/11097 - simplify some CI checks (so that MQ will be easier)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153#issuecomment-5782685565

   > How does this simplify the MQ?
   
   the MQ checks themselves won't change - it's more a minor cleanup to have checks more aligned with each other 🙂
   
   https://github.com/apache/arrow-rs/pull/11097#issuecomment-5706872565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.
sdf-jkl commented on PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153#issuecomment-5782264412

   How does this simplify the MQ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153#issuecomment-5788016023

   thanks @blaginin & @sdf-jkl 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153#discussion_r4061870798


##########
.github/workflows/parquet.yml:
##########
@@ -68,6 +78,12 @@ jobs:
         run: cargo test -p parquet
       - name: Test --all-features
         run: cargo test -p parquet --all-features
+      - name: Test parquet-variant

Review Comment:
   plus, when we merge https://github.com/apache/arrow-rs/pull/11097 we can make some checks only run in the MQ and not on push



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: consolidate Parquet variant checks and fix path filters [arrow-rs]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #11153:
URL: https://github.com/apache/arrow-rs/pull/11153#discussion_r4061866193


##########
.github/workflows/parquet.yml:
##########
@@ -68,6 +78,12 @@ jobs:
         run: cargo test -p parquet
       - name: Test --all-features
         run: cargo test -p parquet --all-features
+      - name: Test parquet-variant

Review Comment:
   this will make the check a bit slower, but it's still not the bottleneck so probably fine? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org