[GitHub] [druid] tejaswini-imply commented on a diff in pull request #13772: Fix GHA tests cache hit miss scenario

["tejaswini-imply (via GitHub)" <gi...@apache.org>]

tejaswini-imply commented on code in PR #13772:
URL: https://github.com/apache/druid/pull/13772#discussion_r1102236606


##########
.github/workflows/reusable-standard-its.yml:
##########
@@ -74,12 +74,15 @@ jobs:
         with:
           path: ~/.m2/repository
           key: maven-${{ runner.os }}-${{ inputs.build_jdk }}-${{ github.sha }}
-          fail-on-cache-miss: true
+
+      - name: Maven build
+        if: steps.maven-restore.outputs.cache-hit != 'true'
+        run: |
+          ./it.sh ci

Review Comment:
   This is a known bug from GHA (https://github.com/actions/cache/issues/810). No, it's not atomic, so we're doing a clean build and running the tests as usual. As this is sporadic, failing the entire suite of tests due to a stuck cache didn't seem wise. Another workaround is to let that particular test with stuck cache download fail and rerun it after the workflow ends, hoping the problem doesn't occur again. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org