You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/29 04:38:51 UTC

[GitHub] [commons-jcs] arturobernalg commented on pull request #33: JCS-209 - Use Collections.singletonList insteadof Arrays.asList when there be only with few arguments

arturobernalg commented on pull request #33:
URL: https://github.com/apache/commons-jcs/pull/33#issuecomment-809059627


   > The toArray() method is supposed to use the provided array if it can take the elements in the collection. So we save creating another object with the pre-allocated array.
   > 
   > I'm fine with the other changes.
   
   Hi @tvand 
   I have reversed the change. the idea of this change was to improve performance.
   
   There is a cool compilations here --> https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_new_reflective_array
   
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org