You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/30 08:53:38 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas
HuangXingBo opened a new pull request #13855:
URL: https://github.com/apache/flink/pull/13855
## What is the purpose of the change
*This pull request use iloc for positional slicing instead of direct slicing in `from_pandas`*
## Brief change log
- *use iloc for positional slicing instead of direct slicing in `from_pandas`*
## Verifying this change
This change added tests and can be verified as follows:
*`test_from_pandas_with_float_index` in `test_pandas_conversion.py`*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13855:
URL: https://github.com/apache/flink/pull/13855#issuecomment-719428887
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b (Fri Oct 30 08:55:33 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19894).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13855:
URL: https://github.com/apache/flink/pull/13855#issuecomment-719444401
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #13855:
URL: https://github.com/apache/flink/pull/13855#discussion_r514952639
##########
File path: flink-python/pyflink/table/tests/test_pandas_conversion.py
##########
@@ -132,6 +132,12 @@ def test_from_pandas(self):
"1970-01-01 00:00:00.123,[hello, 中文],1,hello,"
"1970-01-01 00:00:00.123,[1, 2]"])
+ def test_from_pandas_with_float_index(self):
Review comment:
Is it possible integrate this test case into an existing test case? Then we could avoid introduce another IT case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13855: [FLINK-19894][python] Use iloc for positional slicing instead of direct slicing in from_pandas
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13855:
URL: https://github.com/apache/flink/pull/13855#issuecomment-719444401
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8665",
"triggerID" : "c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4ef2ac24d63eecab3b6c3d1c91083d7b4c4c75b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8665)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org