You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/03/05 12:56:24 UTC
[kudu-CR] Init kudu.write duration accumulator lazily
pengchengliu_bupt@163.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15368
Change subject: Init kudu.write_duration accumulator lazily
......................................................................
Init kudu.write_duration accumulator lazily
Change-Id: I76dea33d652874f9cfcbb72a42ab3061fd1e6974
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/15368/1
--
To view, visit http://gerrit.cloudera.org:8080/15368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76dea33d652874f9cfcbb72a42ab3061fd1e6974
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pe...@163.com>
[kudu-CR] Init kudu.write duration accumulator lazily
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15368 )
Change subject: Init kudu.write_duration accumulator lazily
......................................................................
Patch Set 1:
Yes, this patch should not be needed. See https://github.com/apache/kudu/commit/5f199c16d46fc6bd6003f00d4e56ba75923f192c for details.
Let me know if that patch isn't satisfactory.
--
To view, visit http://gerrit.cloudera.org:8080/15368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76dea33d652874f9cfcbb72a42ab3061fd1e6974
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pe...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 21:37:00 +0000
Gerrit-HasComments: No
[kudu-CR] Init kudu.write duration accumulator lazily
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15368 )
Change subject: Init kudu.write_duration accumulator lazily
......................................................................
Patch Set 1:
I think Grant already addressed this issue within the HdrHistogramAccumulator itself.
--
To view, visit http://gerrit.cloudera.org:8080/15368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76dea33d652874f9cfcbb72a42ab3061fd1e6974
Gerrit-Change-Number: 15368
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <pe...@163.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 19:08:58 +0000
Gerrit-HasComments: No