You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2026/09/04 09:10:02 UTC

[PR] Flag deprecated expose_config=non-sensitive-only in config lint [airflow]

FrankYang0529 opened a new pull request, #72507:
URL: https://github.com/apache/airflow/pull/72507

## Why

- `[api] expose_config = non-sensitive-only` was deprecated in #59880 (3.2.0), but the only signal is a `DeprecationWarning` that the api-server emits once per process while serving `GET /config`.
- On a config file that still carries `non-sensitive-only`, `airflow config lint` and `airflowctl config lint` report "No issues found in your airflow.cfg. It is ready for Airflow 3!".

## How

- Add a value-level `ConfigChange` rule (`was_removed=False`, `is_invalid_if="non-sensitive-only"`) to both `CONFIGS_CHANGES` lists, following the existing rule.

## Verification

- Unit test
- `uv run --frozen --project airflow-core pytest airflow-core/tests/unit/cli/commands/test_config_command.py`
- `uv run --frozen --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_config_command.py`
- Integration test:

```
export AIRFLOW_HOME=/tmp/airflow-lint && mkdir -p $AIRFLOW_HOME
.venv/bin/airflow config lint --section api
sed -i '' 's/^expose_config = .*/expose_config = non-sensitive-only/' $AIRFLOW_HOME/airflow.cfg && grep -n '^expose_config' $AIRFLOW_HOME/airflow.cfg
.venv/bin/airflow config lint
```

On main branch, it shows `No issues found in your airflow.cfg. It is ready for Airflow 3!`. In this branch, it shows:

```
Found issues in your airflow.cfg:
- Invalid value `non-sensitive-only` set for `expose_config` configuration parameter in `api` section. This value is deprecated and treated as
`True`. Set `expose_config` to `True` instead; sensitive configuration values are always masked.

Please update your configuration file accordingly.
```

<!--
Thank you for contributing!

Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/

Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.

For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.

Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.

In case of an existing issue, reference it using one of the following:

* closes: #ISSUE
* related: #ISSUE
-->

---

##### Was generative AI tooling used to co-author this PR?

- [ ] Yes (please specify the tool below)

---

* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flag deprecated expose_config=non-sensitive-only in config lint [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #72507:
URL: https://github.com/apache/airflow/pull/72507#issuecomment-5574669675

   ### Backport failed to create: airflow-ctl/v0-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/34153738808'> Run details </a>
   
   Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
   the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
   
   In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>airflow-ctl/v0-1-test</td>
           <td><a href="https://github.com/apache/airflow/commit/688dff54a085e2a5d22eb3c1d8460252a8a2c5d6"><img src='https://img.shields.io/badge/Commit-688dff5-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker 688dff5 airflow-ctl/v0-1-test
   ```
   
   This should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   
   If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Flag deprecated expose_config=non-sensitive-only in config lint [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk merged PR #72507:
URL: https://github.com/apache/airflow/pull/72507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org