You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 01:43:42 UTC

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16399: [fix][broker] OpReadEntry is not recycled in some corner cases

codelipenghui commented on code in PR #16399:
URL: https://github.com/apache/pulsar/pull/16399#discussion_r914339409


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -48,6 +53,9 @@ class OpReadEntry implements ReadEntriesCallback {
     public static OpReadEntry create(ManagedCursorImpl cursor, PositionImpl readPositionRef, int count,
             ReadEntriesCallback callback, Object ctx, PositionImpl maxPosition) {
         OpReadEntry op = RECYCLER.get();
+        if (createCount != null) {

Review Comment:
   Maybe we can try to recycle the OpReadEntry again in the test to confirm the OpReadEntry is recycled? So that we don't need to introduce this operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org