[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations

["Mike Billau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940696#comment-13940696 ] 

Mike Billau commented on CB-4096:
---------------------------------

[~iclelland], what are the plans for the 'subdomains="true"' flag? There was nothing in the ML thread. The android code still parses out this attribute from the XML and passes the flag around to all of the whitelist methods, it just never utilizes it. It seems trivial to add code in https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/Whitelist.java#L139 like this:
{code}
if( subdomains ){
    if( scheme == null) scheme = "";
    String sub = scheme + "*." + host; // generate *.host subdomain
    addWhiteListEntry(sub, false);
}
{code}

This would ensure back-compatibility for anyone still using the subdomains flag. I think we might as well use this since so much of the code still passes around the subdomain flag. We could add a deprecation notice here.

> Android - Unify Whitelist Implemenations
> ----------------------------------------
>
>                 Key: CB-4096
>                 URL: https://issues.apache.org/jira/browse/CB-4096
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 3.0.0
>            Reporter: Andrew Grieve
>            Assignee: Ian Clelland
>             Fix For: 3.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)