You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/05/17 06:58:55 UTC

[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1490: [CELEBORN-583] Merge pooled memory allocators.

FMX commented on code in PR #1490:
URL: https://github.com/apache/incubator-celeborn/pull/1490#discussion_r1196030506


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3204,6 +3213,22 @@ object CelebornConf extends Logging {
       .intConf
       .createWithDefault(32)
 
+  val MEMORY_POOLED_ALLOCATOR_VERBOSE_METRIC: ConfigEntry[Boolean] =
+    buildConf("celeborn.pooled.allocator.verbose.metric")

Review Comment:
   Sounds reasonable. I'll change it to make it looks consistent with Netty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org