You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Laszlo Bodor (Jira)" <ji...@apache.org> on 2019/08/27 11:50:00 UTC

[jira] [Commented] (HIVE-21962) Replacing ArrayList params with List in and around PlanUtils and MapWork

    [ https://issues.apache.org/jira/browse/HIVE-21962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916644#comment-16916644 ] 

Laszlo Bodor commented on HIVE-21962:
-------------------------------------

pushed to master, thanks [~isuller] for the patch!

> Replacing ArrayList params with List in and around PlanUtils and MapWork
> ------------------------------------------------------------------------
>
>                 Key: HIVE-21962
>                 URL: https://issues.apache.org/jira/browse/HIVE-21962
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ivan Suller
>            Assignee: Ivan Suller
>            Priority: Minor
>         Attachments: HIVE-21962.1.patch, HIVE-21962.1.patch, HIVE-21962.2.patch, HIVE-21962.2.patch
>
>
> Using the implementing class is usually a bad practice. OO suggest to use the least restrictive interface instead. ArrayList is used in many-many methods as a parameter - this is just a tiny part of this work.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)