[GitHub] [airflow] samgans opened a new pull request #16893: Change the logic of None comparison in model_list template

[GitBox <gi...@apache.org>]

samgans opened a new pull request #16893:
URL: https://github.com/apache/airflow/pull/16893


   This PR closes the #16836 and is related to #12315
   
   **Why:**
   
   There was an inconsistency in the UI where the presence of XCOM value was checked by `elif item[value] != None`. That caused a failure in XCOMs view when the user was trying to return not castable to bool XCOM objects (e.g. pandas data frames). Moreover, the method of comparison is not recommended by PEP8:
   
   ```Comparisons to singletons like None should always be done with is or is not, never the equality operators.```
   
   The bug was uncovered by @turbaszek but was not fixed for some reason (probably due to the focus change).
   
   **Changes:**
   
   Change the comparison operator from `!=` to `is not`, which is recommended approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton merged pull request #16893: Change the logic of None comparison in model_list template

[GitBox <gi...@apache.org>]

ryanahamilton merged pull request #16893:
URL: https://github.com/apache/airflow/pull/16893


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16893: Change the logic of None comparison in model_list template

[GitBox <gi...@apache.org>]

boring-cyborg[bot] commented on pull request #16893:
URL: https://github.com/apache/airflow/pull/16893#issuecomment-878322817


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16893: Change the logic of None comparison in model_list template

[GitBox <gi...@apache.org>]

boring-cyborg[bot] commented on pull request #16893:
URL: https://github.com/apache/airflow/pull/16893#issuecomment-876683745


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #16893: Change the logic of None comparison in model_list template

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #16893:
URL: https://github.com/apache/airflow/pull/16893#issuecomment-876687235


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org