You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/01/09 02:37:58 UTC

Review Request 69695: Fixed compile error with Clang 3.5.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69695/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.


Repository: mesos


Description
-------

Fixed compile error with Clang 3.5.


Diffs
-----

  src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 


Diff: https://reviews.apache.org/r/69695/diff/1/


Testing
-------

Compiled Mesos using clang 3.5.0.


Thanks,

Gastón Kleiman


Re: Review Request 69695: Fixed compile error with Clang 3.5.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69695/#review211794
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Jan. 9, 2019, 2:37 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69695/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2019, 2:37 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed compile error with Clang 3.5.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
> 
> 
> Diff: https://reviews.apache.org/r/69695/diff/1/
> 
> 
> Testing
> -------
> 
> Compiled Mesos using clang 3.5.0.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Re: Review Request 69695: Fixed compile error with Clang 3.5.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69695/#review211801
-----------------------------------------------------------



PASS: Mesos patch 69695 was successfully built and tested.

Reviews applied: `['69695']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2733/mesos-review-69695

- Mesos Reviewbot Windows


On Jan. 9, 2019, 2:37 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69695/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2019, 2:37 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed compile error with Clang 3.5.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
> 
> 
> Diff: https://reviews.apache.org/r/69695/diff/1/
> 
> 
> Testing
> -------
> 
> Compiled Mesos using clang 3.5.0.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>