[jira] [Issue Comment Deleted] (FLINK-9665) PrometheusReporter does not properly unregister metrics

["Guokuai Huang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-9665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guokuai Huang updated FLINK-9665:
---------------------------------
    Comment: was deleted

(was: I encountered a problem, which may be a bug introduced by this change. 
https://issues.apache.org/jira/browse/FLINK-22664)

> PrometheusReporter does not properly unregister metrics
> -------------------------------------------------------
>
>                 Key: FLINK-9665
>                 URL: https://issues.apache.org/jira/browse/FLINK-9665
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Metrics
>    Affects Versions: 1.4.2, 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Jelmer Kuperus
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.4.3, 1.5.1, 1.6.0
>
>
> The {{PrometheusReporter}} groups metrics with the same logical scope in a single {{Collector}} which are periodically polled by Prometheus.
> New metrics are added to an existing collector, and a reference count is maintained so we can eventually cleanup the {{Collector}} itself.
> For removed metrics we decrease the reference count, do not however remove the metrics that were added. As a result the collector will continue to expose metrics, as long as at least 1 metric exists with the same logical scope.
> If the collector is a {{io.prometheus.client.Gauge}} we can use the {{#remove()}} method. For histograms we will have to modify our {{HistogramSummaryProxy}} class to allow removing individual histograms.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)