You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2018/07/03 18:30:59 UTC
Re: Review Request 67696: Enable SLA-aware updates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/
-----------------------------------------------------------
(Updated July 3, 2018, 6:30 p.m.)
Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Fix build add additional IT tests.
Repository: aurora
Description
-------
This patch enables SLA-aware updates.
Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
Diff: https://reviews.apache.org/r/67696/diff/3/
Changes: https://reviews.apache.org/r/67696/diff/2-3/
Testing
-------
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
Re: Review Request 67696: Enable SLA-aware updates
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review205697
-----------------------------------------------------------
Ship it!
Master (a6d9288) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 3, 2018, 6:30 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67696/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 6:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch enables SLA-aware updates.
>
> Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
>
> This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
> src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
> src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
> src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
> src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
> src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
> src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
> ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
> ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
>
>
> Diff: https://reviews.apache.org/r/67696/diff/3/
>
>
> Testing
> -------
>
> Added unit tests, `./gradlew test`.
>
> Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67696: Enable SLA-aware updates
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review205783
-----------------------------------------------------------
This looks great! Very easy to read. One thing I noticed is that the comments in the code have better insight into how this is supposed to work than the documentation. Would be nice to get more details in the user-facing docs. Particularly the overlap with maintenance coordinators and this. Example questions I can imagine users having include: how would I run an update which adheres to the maintenance SLA but also never updates more than N total instances? They may be tempted to use the batch size for this and here it would drastically limit their throughput.
- David McLaughlin
On July 3, 2018, 11:29 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67696/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 11:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch enables SLA-aware updates.
>
> Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
>
> This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md edc081f502370190597ad028f3275cdfd572f5ca
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
> docs/features/job-updates.md b52eb35a1de9da40f8a00ef0b905df30069029d3
> docs/reference/configuration.md acab4c58d9ab3c04d156fed3636e77aed6d1faf4
> docs/reference/scheduler-configuration.md 805e516689be019101f7c220c89fd9c391bb93b3
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
> src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
> src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
> src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
> src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
> src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
> src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
> ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
> ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
>
>
> Diff: https://reviews.apache.org/r/67696/diff/4/
>
>
> Testing
> -------
>
> Added unit tests, `./gradlew test`.
>
> Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67696: Enable SLA-aware updates
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review205838
-----------------------------------------------------------
Ship it!
Master (a6d9288) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 8, 2018, 6:48 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67696/
> -----------------------------------------------------------
>
> (Updated July 8, 2018, 6:48 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch enables SLA-aware updates.
>
> Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
>
> This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md edc081f502370190597ad028f3275cdfd572f5ca
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
> docs/features/job-updates.md b52eb35a1de9da40f8a00ef0b905df30069029d3
> docs/reference/configuration.md acab4c58d9ab3c04d156fed3636e77aed6d1faf4
> docs/reference/scheduler-configuration.md 805e516689be019101f7c220c89fd9c391bb93b3
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
> src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
> src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
> src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
> src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
> src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
> src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
> ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
> ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
>
>
> Diff: https://reviews.apache.org/r/67696/diff/5/
>
>
> Testing
> -------
>
> Added unit tests, `./gradlew test`.
>
> Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67696: Enable SLA-aware updates
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/
-----------------------------------------------------------
(Updated July 8, 2018, 6:48 a.m.)
Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Add more user documentation around using the feature
Repository: aurora
Description
-------
This patch enables SLA-aware updates.
Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
Diffs (updated)
-----
RELEASE-NOTES.md edc081f502370190597ad028f3275cdfd572f5ca
api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
docs/features/job-updates.md b52eb35a1de9da40f8a00ef0b905df30069029d3
docs/reference/configuration.md acab4c58d9ab3c04d156fed3636e77aed6d1faf4
docs/reference/scheduler-configuration.md 805e516689be019101f7c220c89fd9c391bb93b3
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
Diff: https://reviews.apache.org/r/67696/diff/5/
Changes: https://reviews.apache.org/r/67696/diff/4-5/
Testing
-------
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly
Re: Review Request 67696: Enable SLA-aware updates
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review205702
-----------------------------------------------------------
Ship it!
Master (a6d9288) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 3, 2018, 11:29 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67696/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 11:29 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This patch enables SLA-aware updates.
>
> Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
>
> This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md edc081f502370190597ad028f3275cdfd572f5ca
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
> docs/features/job-updates.md b52eb35a1de9da40f8a00ef0b905df30069029d3
> docs/reference/configuration.md acab4c58d9ab3c04d156fed3636e77aed6d1faf4
> docs/reference/scheduler-configuration.md 805e516689be019101f7c220c89fd9c391bb93b3
> src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
> src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
> src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
> src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
> src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
> src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
> src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
> src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
> src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
> src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
> src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
> src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
> src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
> ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
> ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
>
>
> Diff: https://reviews.apache.org/r/67696/diff/4/
>
>
> Testing
> -------
>
> Added unit tests, `./gradlew test`.
>
> Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 67696: Enable SLA-aware updates
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/
-----------------------------------------------------------
(Updated July 3, 2018, 11:29 p.m.)
Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb.
Changes
-------
Update documentation
Repository: aurora
Description
-------
This patch enables SLA-aware updates.
Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description.
This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible.
Diffs (updated)
-----
RELEASE-NOTES.md edc081f502370190597ad028f3275cdfd572f5ca
api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f
docs/features/job-updates.md b52eb35a1de9da40f8a00ef0b905df30069029d3
docs/reference/configuration.md acab4c58d9ab3c04d156fed3636e77aed6d1faf4
docs/reference/scheduler-configuration.md 805e516689be019101f7c220c89fd9c391bb93b3
src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679
src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a
src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2
src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679
src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12
src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2
src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148
src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628
src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION
src/test/python/apache/aurora/client/cli/test_inspect.py 2baba2aa55865ec298a4c9e5af3952b56cb9a910
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65
src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae
ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551
ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458
Diff: https://reviews.apache.org/r/67696/diff/4/
Changes: https://reviews.apache.org/r/67696/diff/3-4/
Testing
-------
Added unit tests, `./gradlew test`.
Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected.
Thanks,
Jordan Ly