You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/28 12:06:31 UTC

[GitHub] [tvm] grant-arm commented on a change in pull request #10095: [mircoTVM] Include standalone_crt dependencies in MLF

grant-arm commented on a change in pull request #10095:
URL: https://github.com/apache/tvm/pull/10095#discussion_r794448151



##########
File path: apps/microtvm/ethosu/Makefile
##########
@@ -19,13 +19,13 @@
 
 # Setup build environment
 BUILD_DIR := build
-STANDALONE_CRT_PATH := $(shell python3 -c "import tvm.micro; print(tvm.micro.get_standalone_crt_dir())")
 
 ARM_CPU = ARMCM55
 ETHOSU_PATH = /opt/arm/ethosu
 ETHOSU_DRIVER_PATH ?= ${ETHOSU_PATH}/core_driver
 CMSIS_PATH ?= ${ETHOSU_PATH}/cmsis
 ETHOSU_PLATFORM_PATH ?= ${ETHOSU_PATH}/core_platform
+STANDALONE_CRT_PATH := $(abspath $(BUILD_DIR))/$(shell python3 -c "import json; data=json.load(open('./build/metadata.json')); print([e for e in data['external_dependencies'] if e['short_name'] == 'tvm_standalone_crt'][0]['url'])")

Review comment:
       I wasn't sure which way to go with this.
   I've hard-coded it in the demo Makefile now, which I agree feels more natural.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org