[jira] Updated: (MAHOUT-166) Potpourri 2

["Sean Owen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAHOUT-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen updated MAHOUT-166:
-----------------------------

    Attachment: MAHOUT-166.patch

> Potpourri 2
> -----------
>
>                 Key: MAHOUT-166
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-166
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.2
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.2
>
>         Attachments: MAHOUT-166.patch
>
>
> Another large changelist constructed from FindBugs and IntelliJ analysis. It's big enough I figured I'd run it by the list. Key changes:
> - Making stuff final, private that can be
> - Dead code elimination
> - Simplifying JUnit assertions -- "assertTrue(a.equals(b) == true)" could be "assertEquals(a, b)" for instance. Also fixed some expected/actual value issues
> - Not compiling a Pattern object millions of times -- String.split() and replace()/replaceAll() do this and can be profitably replaced with a precompiled Pattern.
> - Small bug fixes picked up by analysis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.