[jira] [Commented] (AIRFLOW-4564) Azure Container Instance misc. bugs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847067#comment-16847067 ] 

ASF GitHub Bot commented on AIRFLOW-4564:
-----------------------------------------

Trollgeir commented on pull request #5319: [AIRFLOW-4564] Azure Container Instance improvements
URL: https://github.com/apache/airflow/pull/5319
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   - Azure polling errors before container is up fixed
   - Azure polling spam in log from TokenRequest removed (set to WARNING)
   - Environmental variables can be secret
   - Status indication if container fails provisioning
   - No max timer for container-run
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Contrib. No unit-test established for ACI as it requires Azure subscription.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Azure Container Instance misc. bugs
> -----------------------------------
>
>                 Key: AIRFLOW-4564
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4564
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 1.10.3
>            Reporter: Asgeir Berland
>            Assignee: Asgeir Berland
>            Priority: Major
>             Fix For: 1.10.4
>
>
> The Azure Container Instance Operator (and hook) have certain issues:
> * Azure polling errors before the container is running
> * Azure polling spam in log from TokenRequest every second
> * Environmental variables cannot be secret
> * No status if container fails provisioning
> * Max timer for container-run is currently 12 hours



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)